Another try…
Move all wallet RPC commands definitions and dispatch entries to wallet/wallet_rpcdispatch.h.
Allow extending the RPC dispatch table by appending commands when server is not running.
Motivation:
Concept ACK. It’s good that ‘modules’ can register their own RPC calls. The wallet is a prime example of this, but there may be more in the future.
Some nits:
walletRegisterRPCCommands should not be on CWallet. CWallet is the class that implements the wallet not its RPC interface. A better place is in rpcwallet.cpp.walletRegisterRPCCommands implementation should not be in the header file, but in an implementation fileconst CRPCCommand vWalletRPCCommands[] belong in an implementation file, not a header file. Having a data structure initialization in a header file means it can only be included in one place, otherwise there will be duplicate definition errors.
Agreed with and fixed @laanwj points/nits.
Having a data structure initialization in a header file means it can only be included in one place, otherwise there will be duplicate definition errors.
Just curios: wouldn’t this be avoided because of the headers preprocessor marcos (like #ifndef BITCOIN_WALLET_RPCWALLET_H)
77+};
78+
79+void walletRegisterRPCCommands()
80+{
81+ unsigned int vcidx;
82+ for (vcidx = 0; vcidx < (sizeof(vWalletRPCCommands) / sizeof(vWalletRPCCommands[0])); vcidx++)
ut ACK
Note - The need to define functions in rpcwallet.h is greatly diminished. The rpcwallet.cpp externs could be removed from rpcwallet.h right now. The only reference is the in-rpcwallet call table.
rpcwallet.h, kept some (functions of rpcdump.cpp) in rpcwallet.cpp.
Allow extending the rpc dispatch table by appending commands when server is not running.