Dispatching a QThread from a non Qt thread is not allowed. Always use the HTTPRPCTimerInterface (non QT) to dispatch RPCRunLater threads.
Agree that using the order of timerInterfaces is not the best way of identifying the type of the timer interface.
fixes #7316
Tested ACK 9490ec3, indeed fixes #7316 (comment).
Tag "Backport" missing?
Discussed with @laanwj on IRC and i'll try now to remove the set of timers, I think having only one timer makes things more stable for future changes.
Concept ACK, but the change in logic needs to be more explicit. This is too fragile against refactors/reorders (at least for master, for 0.12 as a quick last minute patch it'd be acceptable...). (as discussed on IRC)
Added a commit that removes the std::vector for RPCTimerInterfaces (just one pointer now). Also added a function (RPCSetTimerInterfaceIfUnset) that prevents setting a Qt bases timer interface if already only is set.
Not meant for back porting (will open "the" simple fix for 0.12).
104 | -void RPCRegisterTimerInterface(RPCTimerInterface *iface); 105 | -/** Unregister factory function for timers */ 106 | -void RPCUnregisterTimerInterface(RPCTimerInterface *iface); 107 | +/** Set the factory function for timers */ 108 | +void RPCSetTimerInterface(RPCTimerInterface *iface); 109 | +/** Set the factory function for timer, but only, it unset */
typo: if unset
Thanks. Fixed.
Nice, uTACK
Dispatching a QThread from a non Qt thread is not allowed. Always use the HTTPRPCTimerInterface (non QT) to dispatch RPCRunLater threads.
277 | @@ -278,7 +278,9 @@ RPCConsole::RPCConsole(const PlatformStyle *platformStyle, QWidget *parent) : 278 | #endif 279 | // Register RPC timer interface 280 | rpcTimerInterface = new QtRPCTimerInterface(); 281 | - RPCRegisterTimerInterface(rpcTimerInterface); 282 | + // avoid accidentailly overwrite an existing, non QTThread
s/accidentiailly overwrite/accidentally overwriting
Thanks. Force push fixed.