[qa] Test walletpassphrase timeout #7320

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1601-rpcWalletPass changing 1 files +4 −2

MarcoFalke commented at 12:14 PM on January 8, 2016: member
Test case for #7316

Test code: $ git checkout fadceb7;make;BITCOIND=bitcoin-qt qa/pull-tester/rpc-tests.py keypool
```
...
Running testscript keypool.py ...
Initializing test directory /tmp/testqf3QO4
Assertion failed: 1452255264 != 0
```
jonasschnelli commented at 12:17 PM on January 8, 2016: contributor

Nice! utACK.

But this actually does not test the issue #7316, because the reported issue can only happen when you run bitcoin-qt with -server=1.
MarcoFalke commented at 12:17 PM on January 8, 2016: member

@jonasschnelli See my "test code" ;)

Are you still working on the BITCOIND=bitcoin-qt nightly rpc tests?
jonasschnelli commented at 12:20 PM on January 8, 2016: contributor

@MarcoFalke: Ah. Right. Your testcode looks good. Indeed, this would catch #7316.

Are you still working on the BITCOIND=bitcoin-qt nightly rpc tests?

It's relatively far down on my priority list. But not given up...
jonasschnelli added the label Wallet on Jan 8, 2016
jonasschnelli added the label Tests on Jan 8, 2016
[qa] Test walletpassphrase timeout fa1cb1ae15

in qa/rpc-tests/keypool.py:None in fadceb736b outdated

  69 | @@ -70,9 +70,11 @@ def run_test(self):
  70 |              assert(e.error['code']==-12)
  71 |  
  72 |          # refill keypool with three new addresses
  73 | -        nodes[0].walletpassphrase('test', 12000)
  74 | +        nodes[0].walletpassphrase('test', 1)
  75 |          nodes[0].keypoolrefill(3)
  76 | -        nodes[0].walletlock()
  77 | +        # test walletpassphrase timeout
  78 | +        time.sleep(1)

laanwj commented at 3:22 PM on January 9, 2016:

Concept ACK, but setting a timeout of 1 and then waiting a second is too close. A slight mistiming (e.g. busy machine) would result in a race condition, what about waiting 2 seconds instead?

MarcoFalke force-pushed on Jan 9, 2016

in qa/rpc-tests/keypool.py:None in fa1cb1ae15

  74 | +        nodes[0].walletpassphrase('test', 1)
  75 |          nodes[0].keypoolrefill(3)
  76 | -        nodes[0].walletlock()
  77 | +        # test walletpassphrase timeout
  78 | +        time.sleep(1.1)
  79 | +        assert_equal(nodes[0].getwalletinfo()["unlocked_until"], 0)

luke-jr commented at 5:21 PM on January 15, 2016:

Maybe this ought to actually try to do something to test the wallet relocking?

laanwj merged this on Jan 18, 2016
laanwj closed this on Jan 18, 2016
laanwj referenced this in commit d3dfc6d7e1 on Jan 18, 2016
MarcoFalke deleted the branch on Jan 18, 2016
luke-jr referenced this in commit 3493110558 on Feb 12, 2016
MarcoFalke referenced this in commit 331655253d on Apr 5, 2016
nomnombtc referenced this in commit ed4e80aa5f on Nov 11, 2016
nomnombtc referenced this in commit 00a904eda4 on Nov 12, 2016
nomnombtc referenced this in commit 61df694e11 on Nov 13, 2016
sickpig referenced this in commit c9bddee7e6 on Nov 14, 2016
random-zebra referenced this in commit e5ca48df61 on Oct 3, 2018
random-zebra referenced this in commit 9572856679 on Oct 3, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7316 walletpassphrase timeout doesn't work in bitcoin-qt