[wallet] Clarify rpc help message with regard to rounding #7332

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1601-docAmount changing 2 files +7 −8

MarcoFalke commented at 10:37 AM on January 13, 2016: member

Clean merge into master and 0.12.

Fixes #7331.
jonasschnelli added the label Docs and Output on Jan 13, 2016
jonasschnelli added the label RPC on Jan 13, 2016
jonasschnelli commented at 10:44 AM on January 13, 2016: contributor

Does creatrawtransaction also requires an update?
[wallet] Clarify rpc help message with regard to rounding faf671bca6
MarcoFalke force-pushed on Jan 13, 2016
MarcoFalke commented at 11:25 AM on January 13, 2016: member

Right, it uses AmountFromValue() as well. Good catch!
laanwj merged this on Jan 13, 2016
laanwj closed this on Jan 13, 2016
laanwj referenced this in commit 17ef279304 on Jan 13, 2016
laanwj referenced this in commit 2a3161bf8b on Jan 13, 2016
MarcoFalke deleted the branch on Jan 13, 2016

in src/wallet/rpcwallet.cpp:None in faf671bca6

2178 | @@ -2180,7 +2179,7 @@ UniValue settxfee(const UniValue& params, bool fHelp)
2179 |              "settxfee amount\n"
2180 |              "\nSet the transaction fee per kB. Overwrites the paytxfee parameter.\n"
2181 |              "\nArguments:\n"
2182 | -            "1. amount         (numeric, required) The transaction fee in " + CURRENCY_UNIT + "/kB rounded to the nearest 0.00000001\n"
2183 | +            "1. amount         (numeric or sting, required) The transaction fee in " + CURRENCY_UNIT + "/kB\n"

PRabahy commented at 4:00 PM on January 13, 2016:

Typo.

MarcoFalke commented at 4:02 PM on January 13, 2016:

Thanks, scheduled for rc2 ;)

DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7331 Amount parser is too strict