[qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) #7334

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1601-qt55Workaround changing 1 files +2 −4

MarcoFalke commented at 5:50 PM on January 13, 2016: member
Let's not remove it too early. I'd still prefer something like
```
#if QT_VERSION >= 0x050000 && QT_VERSION <= 0x050500
```
[qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) fa989fbf57
jonasschnelli added the label GUI on Jan 13, 2016

in src/qt/coincontroldialog.cpp:None in fa989fbf57

 407 | @@ -408,10 +408,8 @@ void CoinControlDialog::viewItemChanged(QTreeWidgetItem* item, int column)
 408 |              CoinControlDialog::updateLabels(model, this);
 409 |      }
 410 |  
 411 | -    // todo: this is a temporary qt5 fix: when clicking a parent node in tree mode, the parent node
 412 | -    //       including all children are partially selected. But the parent node should be fully selected
 413 | -    //       as well as the children. Children should never be partially selected in the first place.
 414 | -    //       Should be fixed in Qt5.4 and above. https://bugreports.qt.io/browse/QTBUG-43473
 415 | +    // TODO: Remove this temporary qt5 fix after Qt5.3 and Qt5.4 are no longer used.
 416 | +    //       Fixed in Qt5.5 and above: https://bugreports.qt.io/browse/QTBUG-43473

jonasschnelli commented at 8:31 AM on January 14, 2016:

IMO we should keep the explanation of the workaround. But right, Qt5.4 does not fix the issue, it needs Qt 5.5+ for that.

MarcoFalke commented at 10:23 AM on January 14, 2016:

The linked bug report explains this pretty well. No need to copy that into our source, I guess?

laanwj commented at 12:56 PM on January 14, 2016: member

We're never proactive with removing compatibility workarounds, so I don't think this will make much difference in practice. But ACK for the sake of correctness.
laanwj merged this on Jan 14, 2016
laanwj closed this on Jan 14, 2016
laanwj referenced this in commit e1060c56cc on Jan 14, 2016
MarcoFalke deleted the branch on Jan 14, 2016
codablock referenced this in commit 1f7b032d96 on Sep 5, 2017
UdjinM6 referenced this in commit 690cb58f80 on Sep 7, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels