Add NoRBF to URI Scheme #7343

issue seweso opened this issue on January 14, 2016
  1. seweso commented at 4:30 PM on January 14, 2016: none

    Before Opt-In RBF is deployed it is probably wise to be able to indicated that RBF is not supposed to be used in a payment.

    This might have the added benefit of showing that RBF does not actually kill zero-conf (which many people wrongfully believe).

  2. luke-jr commented at 4:42 PM on January 14, 2016: member

    Core's wallet never sets the RBF flag anyway, so there is literally nothing to add here.

  3. seweso commented at 5:01 PM on January 14, 2016: none

    It is not even going to be an option? Or is that something which will only be added when there is also the option to actually manage RBF transactions?

    Know anything about other wallets who are preparing to enable RBF transactions/management? Would they be able to define a new NoRBF flag amongst themselves?

  4. jonasschnelli commented at 5:08 PM on January 14, 2016: contributor

    There are two open RBF related PRs:

    • #7159 ([RPC] Add RBF opt-in possibilities to rawtx functions)
    • #7132 (Add option to opt into full-RBF when sending funds)

    I'm also working on a QT RBF option.

  5. laanwj commented at 9:55 AM on January 16, 2016: member

    Which URI scheme?

  6. sipa commented at 7:26 PM on January 16, 2016: member

    I guess this would require an extension to BIP21.

  7. seweso commented at 2:00 PM on January 17, 2016: none

    @sipa Yes. It only needs to be a "if you do this, then do it this way please" kind of thing. If Core doesn't yet opt-in to RBF then this doesn't need to be implemented yet. But would be nice if it would get implemented eventually.

  8. dcousens commented at 1:45 PM on January 18, 2016: contributor

    @seweso maybe follow up BIP21 with an extension request? Not sure of the process around that.

  9. seweso referenced this in commit 2c5185a5e9 on Jan 18, 2016
  10. seweso commented at 9:56 PM on January 18, 2016: none

    https://github.com/bitcoin/bips/compare/master...seweso:patch-1

    Although maybe it should be fullrbf=0, because parameter names with "no" in it are weird.

  11. laanwj commented at 11:45 AM on January 19, 2016: member

    Ah, you mean BIP21. You can't just change BIP21, it would need to be a new BIP that extends it, like BIP72.

    At which point you'll probably get the question 'why add the flag to the URI, not to the Payment Protocol'?

  12. laanwj added the label Feature on Jan 19, 2016
  13. laanwj added the label Wallet on Jan 19, 2016
  14. seweso commented at 6:18 PM on January 19, 2016: none

    @laanwj I know what I want, not the how. That's why. Wouldn't an issue tracker for Bip's be handy? For mere mortals I mean

  15. laanwj commented at 12:20 PM on January 20, 2016: member

    Wouldn't an issue tracker for Bip's be handy? For mere mortals I mean

    A central tracker wouldn't work for that. There is no one responsible for BIPs in general. Everyone can submit a BIP and becomes the author of that.

    The most that you can do is mail the author of the specific BIP with your concerns/issues. But as said, be aware that BIPs like BIP22 are set in stone by sake of being implemented by a lot of different software. So the only way to propose an extension is to create a new BIP (see https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki for information on creating BIPs), not by changing the old one.

  16. seweso commented at 4:54 PM on January 21, 2016: none

    @laanwj Well some kind of naming convention for extension BIP's would be nice (like BIP21E01). And having the entire scheme in one place is handy. Is there something like that?

    Is the name "NoRBF" at least reasonable?

  17. laanwj commented at 10:29 AM on January 22, 2016: member

    You don't need a new naming convention. BIPs have a number, not a name. There is no issue heree, you can just refer to the original BIP. I've given an example above of another BIP that extends the URI scheme.

    Would be better to discuss this on the -dev mailing list instead.

  18. laanwj commented at 11:06 AM on April 28, 2016: member

    As said above, this needs a BIP with an URI extension proposal, this cannot be considered before that. Closing as this is the wrong place.

  19. laanwj closed this on Apr 28, 2016

  20. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me