Banlist updates #7350

pull luke-jr wants to merge 5 commits into bitcoin:master from luke-jr:20150703_banlist_updates changing 1 files +30 −24

luke-jr commented at 5:16 AM on January 15, 2016: member

Recovering #6371 which was basically ready to merge when @Diapolo decided to leave

banlist: update set dirty to be more fine grained

- move the SetBannedSetDirty(false) call from DumpData() into DumpBanlist()
- ensure we only set false, if the write succeeded

57c77fe4d3

banlist: better handling of banlist in StartNode()

- only start working on/with banlist data, if reading in the banlist from
  disk didn't fail
- as CNode::setBannedIsDirty is false (default) when reading fails, we
  don't need to explicitly set it to false to prevent writing
  banlist.dat in that case either

ce479aaada

banlist: add more banlist infos to log / add GUI signal

- to match the peers.dat handling also supply a debug.log entry for how
  many entries were loaded from banlist.dat and how long it took
- add a GUI init message for loading the banlist (same as with peers.dat)

- move the same message for peers.dat upwards in the code, to be able to
  reuse the timing variable nStart and also just log, if our read from
  peers.dat didn't fail

2977c243ef

banlist (bugfix): allow CNode::SweepBanned() to run on interval

- allows CNode::SweepBanned() to run, even if !CNode::BannedSetIsDirty(),
  because if nBanUntil is over we want the ban to be disabled for these
  nodes

e8600c924d

Merge branch 'master' into 20150703_banlist_updates 5bc4fb7b60
dcousens commented at 5:46 AM on January 15, 2016: contributor

@luke-jr why 5bc4fb7? Rebase?
luke-jr commented at 5:53 AM on January 15, 2016: member

@dcousens Rebasing is bad.
MarcoFalke commented at 7:06 AM on January 15, 2016: member

This looks like consistency cleanup/refactor. Any new feature to test here?
jonasschnelli commented at 7:28 AM on January 15, 2016: contributor

Thanks. utACK.
jonasschnelli added the label Refactoring on Jan 15, 2016
dcousens commented at 11:50 AM on January 15, 2016: contributor

utACK 5bc4fb7
MarcoFalke commented at 12:21 PM on January 15, 2016: member

utACK 5bc4fb7
laanwj merged this on Jan 20, 2016
laanwj closed this on Jan 20, 2016
laanwj referenced this in commit 5578144413 on Jan 20, 2016
luke-jr referenced this in commit d86297e56c on Jun 9, 2016
luke-jr referenced this in commit 591aa0801a on Jun 26, 2016
zkbot referenced this in commit d0b67191e2 on Apr 5, 2018
Fuzzbawls referenced this in commit 7c78ece64d on Mar 4, 2020
zkbot referenced this in commit bf0f1cbee9 on Mar 6, 2020
wqking referenced this in commit cf21b99856 on Aug 5, 2020
zkbot referenced this in commit 2d9a9aaa83 on Nov 11, 2020
zkbot referenced this in commit f40121446d on Nov 12, 2020
zkbot referenced this in commit 049951dc45 on Feb 11, 2021
zkbot referenced this in commit b3a6729944 on Feb 16, 2021
zkbot referenced this in commit e85265fbd5 on Feb 17, 2021
zkbot referenced this in commit b4b07a1bbd on Feb 17, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6371 banlist updates