Update license year range to 2016 #7363

pull prayagverma wants to merge 1 commits into bitcoin:master from prayagverma:patch-1 changing 4 files +4 −4
  1. prayagverma commented at 5:15 pm on January 17, 2016: contributor
  2. MarcoFalke commented at 5:32 pm on January 17, 2016: member
    Please also fix it in qt.
  3. prayagverma force-pushed on Jan 17, 2016
  4. prayagverma commented at 5:53 pm on January 17, 2016: contributor

    @MarcoFalke Sorry for my lack of information. I am unaware of what qt means

    I was just passing through and saw the copyright year being not updated, therefore I made the pull request for the same.

    I went through your previous commit ( 9be08b7fe2b6fc81afd0ff4a ) and have updated my pull request accordingly.

    If this isn’t what you meant, if you can point me in the direction of what needs to be done, then I would surely do that

  5. MarcoFalke commented at 6:03 pm on January 17, 2016: member
    Qt is our GUI framework. Please look at edbc9045cb21020d0cc19d226f55ee169e2ffb92
  6. Update license year range to 2016 bd34174ebc
  7. prayagverma force-pushed on Jan 17, 2016
  8. prayagverma commented at 6:09 pm on January 17, 2016: contributor
    @MarcoFalke Thanks for guiding. I have updated the pull request with the changes you suggested
  9. laanwj commented at 9:28 am on January 18, 2016: member
    Yes we should get rid of the duplication between clientversion.h and configure.ac some time. Note that this has nothing to do with qt.
  10. laanwj commented at 9:28 am on January 18, 2016: member
    utACK
  11. laanwj added the label Docs and Output on Jan 18, 2016
  12. laanwj merged this on Jan 18, 2016
  13. laanwj closed this on Jan 18, 2016

  14. laanwj referenced this in commit 2350ab28fb on Jan 18, 2016
  15. laanwj referenced this in commit 098fcb5694 on Jan 18, 2016
  16. MarcoFalke commented at 10:39 am on January 18, 2016: member
    Our qt GUI is the most prominent sink of COPYRIGHT_YEAR.
  17. MarcoFalke commented at 10:39 am on January 18, 2016: member
    post merge utACK bd34174 @pra85 Thanks for sticking with this.
  18. prayagverma commented at 10:44 am on January 18, 2016: contributor
    I am glad that I could be helpful in some way :smile:
  19. laanwj commented at 10:50 am on January 18, 2016: member

    Our qt GUI is the most prominent sink of COPYRIGHT_YEAR.

    Yes, but see the #if defined(HAVE_CONFIG_H). COPYRIGHT_YEAR comes from config/bitcoin-config.h. Effectively, at least for build configurations that we support, the content of clientversion.h will never be used. The duplication is there as an old crutch to support building without autotools. But there have been so many additions to bitcoin-config.h and platform detection over the last versions that this has become unrealistic anyway.

  20. jonasschnelli referenced this in commit 4af58a1c03 on Jan 24, 2017
  21. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-24 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me