[Tests] Eliminate race condition in mempool_packages.py #7368

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:fix-package-test changing 1 files +9 −0

sdaftuar commented at 4:21 AM on January 18, 2016: member

I noticed intermittent failures in the mempool_packages.py RPC test; turns out I introduced a race condition in a recent pull (#7062).

Before this change, node1 could either be in sync or out of sync with node0 after invalidateblock was called, depending on how fast that happened. The test would fail if they were out of sync. This fixes the test by enforcing that their tips stay synced up. @laanwj Note that this bug is in 0.12, in case you think this should be backported or included in the next 0.12 release candidate.
Eliminate race condition in mempool_packages test 4d10d2e16f
MarcoFalke commented at 7:19 AM on January 18, 2016: member

ACK 4d10d2e.

Also needs to be tagged with [Backport]
jonasschnelli added the label Tests on Jan 18, 2016
jonasschnelli added the label Needs backport on Jan 18, 2016
laanwj merged this on Jan 18, 2016
laanwj closed this on Jan 18, 2016
laanwj referenced this in commit f2cf071e70 on Jan 18, 2016
laanwj referenced this in commit 1488fc8eac on Jan 18, 2016
laanwj removed the label Needs backport on Feb 4, 2016
random-zebra referenced this in commit b6c873dbc7 on Apr 7, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels