I'm running 0.12RC1 and tested banning a peer from the GUI. That worked properly, but after an hour passed the peer is still showing up in the banned list.
Peers don't appear to be unbanned automatically #7377
issue PRabahy opened this issue on January 19, 2016-
PRabahy commented at 3:49 AM on January 19, 2016: contributor
- laanwj added the label P2P on Jan 19, 2016
-
PRabahy commented at 12:19 AM on January 20, 2016: contributor
I restarted my node and the Banned peer had gotten cleared out.
-
jonasschnelli commented at 9:10 AM on January 20, 2016: contributor
Thanks for reporting. There are cases where banned nodes still are listed in the table together with the correct "banned until" timestamp. I guess this behavior is okay. IIRC we don't use a watch-thread to save some resources.
- laanwj added the label GUI on Jan 20, 2016
-
laanwj commented at 12:42 PM on January 20, 2016: member
You don't need a thread, but some kind of notification toward the GUI would be nice. Very low priority though, as it is working, just a visual issue.
-
jonasschnelli commented at 1:22 PM on January 20, 2016: contributor
The question is, which event should be (miss)used for updating the
banTableModel. Unbanning a node is not an real-event (because it's caused by time). We could update the list every 10 seconds... but as said, I don't want to waste a timer for this visual glitch. - laanwj added the label Priority Low on Feb 16, 2016
- laanwj removed the label Priority Low on Dec 6, 2017
-
MarcoFalke commented at 6:29 PM on May 8, 2020: member
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Closing due to lack of interest. Pull requests with improvements are always welcome.
- MarcoFalke closed this on May 8, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors