salvagewallet drops valid keys #7379

1. 
   MarcoFalke commented at 5:54 pm on January 19, 2016: member

   Need to look into this next week but I will disable the check in travis in the meantime.

   0check -salvagewallet
   1Assertion failed: [Decimal('33.99911140'), Decimal('5549.99796160'), Decimal('65.99974900')] != [Decimal('0E-8'), Decimal('5549.99796160'), Decimal('65.99974900')]
   

   Edit: Will submit a proper fix tomorrow…

2. jonasschnelli added the label Bug on Jan 20, 2016
3. jonasschnelli added the label Wallet on Jan 20, 2016
4. 
   laanwj commented at 12:47 pm on January 22, 2016: member

   “Hopefully” fixed by #7381
5. 
   laanwj commented at 9:14 am on February 5, 2016: member

   Another intermittent problem in salvagewallet, from https://travis-ci.org/bitcoin/bitcoin/jobs/107074798

    0check -salvagewallet
    1start_node: bitcoind started, calling bitcoin-cli -rpcwait getblockcount
    2start_node: calling bitcoin-cli -rpcwait getblockcount returned
    3start_node: bitcoind started, calling bitcoin-cli -rpcwait getblockcount
    4start_node: calling bitcoin-cli -rpcwait getblockcount returned
    5start_node: bitcoind started, calling bitcoin-cli -rpcwait getblockcount
    6start_node: calling bitcoin-cli -rpcwait getblockcount returned
    7Assertion failed: [Decimal('33.99911140'), Decimal('5549.99796180'), Decimal('59.99974800')] != [Decimal('0E-8'), Decimal('5549.99796180'), Decimal('59.99974800')]
    8  File "/home/travis/build/bitcoin/bitcoin/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/test_framework/test_framework.py", line 135, in main
    9    self.run_test()
   10  File "/home/travis/build/bitcoin/bitcoin/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/wallet.py", line 274, in run_test
   11    assert_equal(balance_nodes, [self.nodes[i].getbalance() for i in range(3)])
   12  File "/home/travis/build/bitcoin/bitcoin/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/test_framework/util.py", line 415, in assert_equal
   13    raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
   14Stopping nodes
   15Cleaning up
   16Failed
   

6. 
   MarcoFalke commented at 8:14 pm on February 5, 2016: member

   I am aware of that. Need to look into this soon™
7. laanwj referenced this in commit 85695802e2 on Feb 15, 2016
8. laanwj referenced this in commit ca8fb59ae1 on Feb 15, 2016
9. MarcoFalke referenced this in commit fa3fafc960 on Apr 12, 2016
10. UdjinM6 referenced this in commit d6f3ae95db on May 30, 2017
11. lateminer referenced this in commit 289e2f80b4 on Jan 7, 2018
12. furszy referenced this in commit 89cc1c454b on Oct 26, 2020
13. furszy referenced this in commit 11c17eb18b on Oct 28, 2020
14. furszy referenced this in commit 680f6fb18c on Nov 6, 2020
15. furszy referenced this in commit 6a0c59af25 on Nov 11, 2020
16. 
    adamjonas commented at 0:02 am on July 26, 2022: member

    -salvagewallet was removed in #18918
17. adamjonas closed this on Jul 26, 2022

    ---

18. bitcoin locked this on Jul 26, 2023

Contributors
MarcoFalke laanwj adamjonas

Labels
Bug Wallet