The variables "fReopenDebugLog" and "fRequestShutdown" should use the data type "sig_atomic_t" (instead of "bool").
I reported this issue for another evolving software before.
-
elfring commented at 7:24 AM on January 28, 2016: none
- jonasschnelli added the label Refactoring on Jan 28, 2016
-
jonasschnelli commented at 7:43 AM on January 28, 2016: contributor
-
laanwj commented at 10:04 AM on January 28, 2016: member
ACK. Why not make the code change (in a PR) instead of raising an issue?
-
elfring commented at 10:11 AM on January 28, 2016: none
There might be more implementation details to reconsider than a change for the data type of two variables. Do you see the need for any more source code fine-tuning for such an use case?
-
laanwj commented at 12:53 PM on February 16, 2016: member
I don't think so. Also, any such (code review) issues can be discussed on a PR that makes this change just as well :)
- laanwj added the label Easy to implement on Apr 28, 2016
-
catilac commented at 11:54 PM on May 3, 2016: contributor
Is anyone working on this? I'm looking for a first task :)
-
MarcoFalke commented at 8:59 AM on May 4, 2016: member
@catilac There is no open pull for this, so I don't think so. Go ahead :+1:
- laanwj closed this on May 12, 2016
- DrahtBot locked this on Sep 8, 2021
