[travis] Exit early when check-doc.py fails #7455

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1601-travisCheckDoc changing 1 files +1 −1

MarcoFalke commented at 3:38 PM on February 1, 2016: member

Discussed on IRC
laanwj commented at 3:41 PM on February 1, 2016: member

Concept ACK.

Can we test this by making a dummy change and see if travis fails, and how it looks now?
laanwj added the label Tests on Feb 1, 2016
MarcoFalke force-pushed on Feb 1, 2016
MarcoFalke force-pushed on Feb 1, 2016
MarcoFalke force-pushed on Feb 1, 2016
MarcoFalke force-pushed on Feb 1, 2016
MarcoFalke force-pushed on Feb 1, 2016
MarcoFalke commented at 8:03 PM on February 1, 2016: member

dummy change: https://travis-ci.org/bitcoin/bitcoin/builds/106296202

TBH, I don't like the set -e workaround, as the travis build will not exit cleanly. It doesn't matter with the current .travis.yml but it may in the future and it is not considered best practice.
laanwj commented at 11:28 AM on February 2, 2016: member

@theuni any ideas here? We want to terminate the test prematurely if the doc check fails, to avoid wasting resources, is there a nicer way to do this then set -e or exit?
MarcoFalke commented at 12:46 PM on February 2, 2016: member

@laanwj You could "remember" the exit code and branch subsequent statements/lines but this is a somewhat larger diff, I guess.
MarcoFalke commented at 10:02 AM on February 26, 2016: member

@laanwj The first commit should be uncontroversial and improve things considerably without making anything worse. Would you mind if I create a new pull for this commit?
laanwj commented at 2:22 PM on March 2, 2016: member

As this is a testing/build system related pull, I'd just like @theuni to take a look at it. If he's ok with it we'll just merge.
theuni commented at 1:31 AM on March 3, 2016: member

@MarcoFalke I think it'd do what you wanted if you just bumped it up into before_script. Then you wouldn't have to worry about forcing an exit, as before_script errors the build on any non-zero return.
theuni commented at 1:32 AM on March 3, 2016: member

other than that, ACK.
[travis] Exit early when check-doc.py fails fa5f19319a
MarcoFalke force-pushed on Mar 3, 2016
MarcoFalke force-pushed on Mar 3, 2016
MarcoFalke commented at 3:23 PM on March 3, 2016: member

Thanks for letting me know. This is indeed working: https://travis-ci.org/bitcoin/bitcoin/jobs/113383026
laanwj merged this on Mar 3, 2016
laanwj closed this on Mar 3, 2016
laanwj referenced this in commit 7f966713a4 on Mar 3, 2016
MarcoFalke deleted the branch on Mar 3, 2016
codablock referenced this in commit 6ca515e4e9 on Sep 16, 2017
codablock referenced this in commit 8716aa04b5 on Sep 19, 2017
codablock referenced this in commit f9777b8c68 on Dec 9, 2017
codablock referenced this in commit 6f68ec6fe7 on Dec 9, 2017
codablock referenced this in commit 53ec957122 on Dec 9, 2017
codablock referenced this in commit 48eddeea29 on Dec 11, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels