[rpc-tests] Change solve() to use rehash #7468

pull mrbandrews wants to merge 1 commits into bitcoin:master from mrbandrews:ba-fix-rehash changing 1 files +1 −1

mrbandrews commented at 7:53 PM on February 4, 2016: contributor

Small fix to the p2p test framework (mininode, etc) that I ran into when belatedly testing PR 7225.

I think it's better for solve() to recompute the hash before the first attempt so we're not using a cached hash, which if wrong, would almost certainly be a bug in the test.
[rpc-tests] Change solve() to use rehash 7689041c03
laanwj added the label Tests on Feb 4, 2016
sdaftuar commented at 8:04 PM on February 4, 2016: member

utACK 7689041c03278a09c88a2bb78cd00217f6d4b1de

This has bitten me before too...
laanwj added the label Needs backport on Feb 5, 2016
laanwj merged this on Feb 5, 2016
laanwj closed this on Feb 5, 2016
laanwj referenced this in commit cf63d5c710 on Feb 5, 2016
laanwj commented at 7:40 PM on February 10, 2016: member

Cherry-picked to 0.12 as 947c4ff72495e1af6dca68c285d967269d5c911
laanwj referenced this in commit 947c4ff724 on Feb 10, 2016
laanwj removed the label Needs backport on Feb 10, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels