The old configure.ac did not work for a copyright holders string containing commas due to insufficient quoting. The new one allows this. While this is, of course, not of direct consequence to the current code (where the string is "Bitcoin Core"), it should still be fixed now that the string is actually factored out.
Fix quoting of copyright holders in configure.ac. #7477
pull domob1812 wants to merge 1 commits into bitcoin:master from domob1812:configure-quoting changing 1 files +3 −3-
domob1812 commented at 1:08 PM on February 7, 2016: contributor
-
72fd008e7f
Fix quoting of copyright holders in configure.ac.
The old configure.ac did not work for a copyright holders string containing commas due to insufficient quoting. The new one allows this. While this is, of course, not of direct consequence to the current code (where the string is "Bitcoin Core"), it should still be fixed now that the string is actually factored out.
-
domob1812 commented at 1:09 PM on February 7, 2016: contributor
Note that I'm not an expert in m4, so I cannot really tell whether the fix is "correct". It just works in my trials.
- laanwj added the label Build system on Feb 8, 2016
-
laanwj commented at 11:38 AM on February 8, 2016: member
utACK, although this pretty much "fixes" a problem that we don't have. Derived projects with commas in their copyright string could also add the extra
[]. -
sipa commented at 11:40 AM on February 8, 2016: member
Seems this also makes an unrelatef change (copyright year instead of version is release)?
-
laanwj commented at 11:45 AM on February 8, 2016: member
@sipa Correct. Though I think that change makes sense
-AC_DEFINE(COPYRIGHT_YEAR, _COPYRIGHT_YEAR, [Version is release]) +AC_DEFINE(COPYRIGHT_YEAR, _COPYRIGHT_YEAR, [Copyright year])Currently we get this in
src/config/bitcoin-config.h:/* Version is release */ #define COPYRIGHT_YEAR 2016 -
domob1812 commented at 5:11 PM on February 8, 2016: contributor
Yes, I agree - this is not high priority for Bitcoin. However, since we actually factored the copyright holders out, I think it makes sense to do it "correctly".
True, the copyright-year change is unrelated - but I stumbled upon it while editing, and think it also makes sense and is trivial enough. But I can also remove it from the PR if you prefer.
-
luke-jr commented at 8:44 PM on February 8, 2016: member
Hmm, I didn't expect multiple things in the substitution part, and the CopyrightHolders function probably won't react correctly to that. But utACK I suppose, this change shouldn't hurt.
-
laanwj commented at 10:14 AM on February 9, 2016: member
Hmm, I didn't expect multiple things in the substitution part, and the CopyrightHolders function probably won't react correctly to that.
Right. Would make sense to have a Tested ACK here before merge.
- laanwj merged this on Mar 31, 2016
- laanwj closed this on Mar 31, 2016
- laanwj referenced this in commit 28ad4d9fc2 on Mar 31, 2016
- codablock referenced this in commit 44e5326399 on Sep 16, 2017
- codablock referenced this in commit ada9fc1a66 on Sep 19, 2017
- codablock referenced this in commit f889475713 on Dec 9, 2017
- codablock referenced this in commit 13a5678683 on Dec 19, 2017
- codablock referenced this in commit 960cb014d3 on Dec 19, 2017
- MarcoFalke locked this on Sep 8, 2021
Labels