This probably doesn't make sense to merge to Core itself due to the added dependencies (rsvg & imagemagick; and icnsutils for Mac) and risks (of installed rsvg mis-rendering the SVG), but posting it here (insta-close) for potential review and/or cherry-picking.
Render icons from SVG #7483
pull luke-jr wants to merge 8 commits into bitcoin:master from luke-jr:svg_icon changing 18 files +91 −18-
luke-jr commented at 9:37 PM on February 8, 2016: member
-
Reuse Windows ICO for Windows installer 68affa72e5
-
fc2e7ac9db
gitian: Dependencies for rendering icons
icnsutils is needed on linux/win for generating the .icns in source tarball
-
Render some icons when possible d46bc51b45
-
Render NSIS wizard sidebar image 6b26b76441
- luke-jr closed this on Feb 8, 2016
- luke-jr reopened this on Feb 8, 2016
- luke-jr force-pushed on Feb 8, 2016
- luke-jr closed this on Feb 8, 2016
- luke-jr reopened this on Feb 8, 2016
- luke-jr force-pushed on Feb 8, 2016
-
luke-jr commented at 10:24 PM on February 8, 2016: member
(Leaving it open for final branch updates/Travis testing)
- luke-jr force-pushed on Feb 8, 2016
- luke-jr force-pushed on Feb 8, 2016
- luke-jr force-pushed on Feb 8, 2016
- luke-jr force-pushed on Feb 8, 2016
- luke-jr force-pushed on Feb 8, 2016
-
Rather than clean generated icons, plan to distribute them 174b80fd73
-
Add 8-bit icon to make builds deterministic again 5dee68c320
- luke-jr force-pushed on Feb 9, 2016
- luke-jr force-pushed on Feb 9, 2016
- luke-jr force-pushed on Feb 9, 2016
- luke-jr force-pushed on Feb 9, 2016
-
Travis: Include dependencies for building icons 1bf3bf605e
-
Merge branch 'svg_icon-0.12.x' into svg_icon da30a0121f
- luke-jr force-pushed on Feb 9, 2016
-
luke-jr commented at 7:09 AM on February 10, 2016: member
Ok, this seems to be working good now.
- luke-jr closed this on Feb 10, 2016
- luke-jr referenced this in commit 8c48545c49 on Jun 28, 2016
- luke-jr referenced this in commit 42dd42a966 on Jun 29, 2016
- luke-jr referenced this in commit eddc4b2c15 on Jun 30, 2016
-
rebroad commented at 1:19 AM on September 25, 2016: contributor
Why the instaclose? If it's good enough for Knots, then why wouldn't it be good enough for Core? And if it's not needed for Core, then why is it needed for Knots?
- DrahtBot locked this on Sep 8, 2021
