Update the wallet best block marker when pruning #7502

pull sipa wants to merge 1 commits into bitcoin:master from sipa:betterflush changing 1 files +1 −1

sipa commented at 2:48 PM on February 10, 2016: member

When pruning, make sure that we update the wallet best block before deleting any files.
laanwj added the label Wallet on Feb 10, 2016
laanwj commented at 2:49 PM on February 10, 2016: member

utACK

Note: intended to fix #7494.
Update the wallet best block marker when pruning e4eebb604e
sipa force-pushed on Feb 10, 2016
sipa renamed this:
~~Update the wallet best block marker before pruning~~
Update the wallet best block marker when pruning
on Feb 10, 2016
sipa commented at 4:13 PM on February 10, 2016: member

Updated the logic to just always update the wallet best block when the chainstate is flushed. Both are relatively slow operations, so this shouldn't have a strong effect on performance.

There are further problems with the flushing logic, which will require a more invasive change, but those problems can only trigger when a crash during flushing happens.
morcos commented at 4:21 PM on February 10, 2016: member

utACK
sdaftuar commented at 4:22 PM on February 10, 2016: member

utACK. Needs backport!
laanwj added the label Needs backport on Feb 10, 2016
sdaftuar commented at 6:29 PM on February 10, 2016: member

Verified that I can trigger the problem reported in #7494 by stopping bitcoind cleanly after the first blocks are pruned (restarting then fails).

Verified further that this pull fixes the issue.

ACK e4eebb604e19f67b0c7a483b1ded1229d75ecdd3
laanwj commented at 6:39 PM on February 10, 2016: member

@sdaftuar thanks for testing!
laanwj merged this on Feb 10, 2016
laanwj closed this on Feb 10, 2016
laanwj referenced this in commit b93f078496 on Feb 10, 2016
laanwj referenced this in commit 1329963001 on Feb 10, 2016
laanwj commented at 7:35 PM on February 10, 2016: member

Cherry-picked to 0.12 as 13299630013411b1a9c77d2332f9d2d45eacde0f
laanwj removed the label Needs backport on Feb 10, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels