Crystal clean make clean #7504

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160210_crystal_clean_make_clean changing 1 files +1 −0

paveljanik commented at 7:15 PM on February 10, 2016: contributor

Fixes #7501.
paveljanik commented at 7:15 PM on February 10, 2016: contributor

@theuni Please have a look please.
laanwj added the label Build system on Feb 10, 2016
laanwj commented at 7:42 PM on February 10, 2016: member

utACK
theuni commented at 7:53 PM on February 10, 2016: member
@paveljanik Please don't use wildcards unless absolutely necessary, especially when deleting.

You should be able to simply:
```
CLEANFILES += $(EXTRA_LIBRARIES)
```
There's no need to clean qt manually, as it's not third-party.
paveljanik commented at 7:57 PM on February 10, 2016: contributor

@theuni But make clean doesn't clean in qt dir as @laanwj reported... Will test $(EXTRA_LIBRARIES)...
make clean should clean .a files ae6eca0f49
paveljanik force-pushed on Feb 10, 2016
paveljanik commented at 8:11 PM on February 10, 2016: contributor

Works much better! Thanks.
theuni commented at 8:11 PM on February 10, 2016: member
@paveljanik In Makefile.qt.include:
```
EXTRA_LIBRARIES += qt/libbitcoinqt.a
```
So that should take care of it.
theuni commented at 8:39 PM on February 10, 2016: member

Thanks, ut ack.
laanwj commented at 9:36 AM on February 15, 2016: member
BTW (no need to be in this PR) it would be nice to add a 'crystal clear' check to the test suite, could be interleaved with the current build process, just taking a snapshot of files here and there, then cleaning afterwards and checking:
```
./autogen.sh
git ls-files -o > $TMPDIR/after_autogen.txt
./configure
git ls-files -o > $TMPDIR/after_configure.txt
make 
...
make clean
git ls-files -o > $TMPDIR/after_clean.txt
make distclean
git ls-files -o > $TMPDIR/after_distclean.txt
# Check
diff $TMPDIR/after_configure.txt $TMPDIR/after_clean.txt
diff $TMPDIR/after_distclean.txt $TMPDIR/after_autogen.txt
```
(needs at least one excemption: looks like make clean leaves behind .dirstamp files which do get cleaned up by make distclean)
laanwj commented at 9:44 AM on February 15, 2016: member
Tested using this patch, and with the above steps. Only one snag:
- make clean leaves behind one file that is not present after configure: src/obj/build.h, but this is cleaned up by make distclean, so may be a false positive
ACK, it solves the issue I raise in #7501
laanwj merged this on Feb 15, 2016
laanwj closed this on Feb 15, 2016
laanwj referenced this in commit 19324cf09c on Feb 15, 2016
theuni commented at 5:55 PM on February 15, 2016: member

@laanwj 'make distcheck' should do what you're after, i think? Been a while since I've tried it, I wouldn't be surprised if it's currently broken.
laanwj commented at 7:34 AM on February 16, 2016: member

@theuni Yes, that's probably what I've been emulating. I had no idea there was a built-in command for that.
codablock referenced this in commit 63bb9416e2 on Sep 16, 2017
codablock referenced this in commit caa79d66e0 on Sep 19, 2017
codablock referenced this in commit 7fc8d35ce5 on Dec 9, 2017
codablock referenced this in commit 5293538e0c on Dec 9, 2017
codablock referenced this in commit cd7a2e2b5a on Dec 11, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7501 'make clean' doesn't clean all build results