Bugfix: Rename descendantfees to descendantmodfees #7529

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:bugfix_descendantfees changing 1 files +2 −2
  1. luke-jr commented at 3:04 AM on February 13, 2016: member

    #7062 changed the meaning of "descendantfees" without changing the name.

    "descendantfees" with the previous (and expected) meaning is about to be released in 0.12, so this will be a regression in 0.13.

    If #7062 is indeed a relevant fix, it should be backported to 0.12, but either way IMO this needs to be renamed to convey what it actually is (if #7062 is backported, this should be as well).

  2. Bugfix: Rename descendantfees to descendantmodfees ab1d1cbbca
  3. Merge branch 'master' into bugfix_descendantfees da1ab6abaf
  4. luke-jr commented at 3:09 AM on February 13, 2016: member

    Oops, looks like #7062 was in fact already backported. So this probably should be, but maybe too late...

  5. sdaftuar commented at 11:21 AM on February 13, 2016: member

    Since most users don't, I believe, use prioritisetransaction, I don't think the name change matters at all, though I would have been happy to change it to be more acceptable during the review of #7062.

    Seems way too late in the 0.12 release cycle to bike shed the rpc field, and I don't think we should only make the change in master and needlessly introduce incompatibility between the about-to-be -released 0.12 and future versions.

    Aside from that concern I'm indifferent to this change.

  6. laanwj commented at 11:42 AM on February 15, 2016: member

    I'm indifferent to this too, weak NACK.

    The mempool code is still in flux, and this is an internal implementation detail that is exposed, next release there may have been changes again. Bike shedding on naming is just a waste of time.

  7. laanwj added the label RPC on Feb 16, 2016
  8. luke-jr closed this on Feb 25, 2016

  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me