Minimal RPC & wallet support for CLTV-enabled multisig addresses #7534

pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:cltv_address changing 13 files +280 −28

luke-jr commented at 12:26 PM on February 14, 2016: member
Possible next steps:
- Enable CLTV-by-time in wallet.
- Add date/time lock chooser to Receive tab in GUI.
- Some way for the recipient to prove to the sender that the address is CLTV.
(this feature was requested on reddit)

in src/wallet/rpcwallet.cpp:None in 8cfb86d70e outdated

1069 | @@ -1070,7 +1070,10 @@ UniValue addmultisigaddress(const UniValue& params, bool fHelp)
1070 |              "       \"address\"  (string) bitcoin address or hex-encoded public key\n"
1071 |              "       ...,\n"
1072 |              "     ]\n"
1073 | -            "3. \"account\"      (string, optional) DEPRECATED. An account to assign the addresses to.\n"
1074 | +            "3. options        (object, optional)\n"
1075 | +            "   {\n"
1076 | +            "     \"cltv_height\"  (numeric, optional) Minimum block height before received funds can be spent\n"

btcdrak commented at 11:23 AM on February 15, 2016:

What about cltv_time as in the createmultisig RPC?

luke-jr commented at 5:52 PM on February 15, 2016:

This is more complex. SelectCoins will need to be taught not to mix height and time locked coins, and FundTransaction to use time rather than height (preferably in more than merely cases that require it, for privacy). Note the code in this RPC call specifically blocks cltv_time for now.

laanwj added the label Wallet on Feb 15, 2016
jonasschnelli added the label GUI on Feb 19, 2016

in src/script/standard.cpp:None in 8cfb86d70e outdated

 160 | +                try {
 161 | +                    sn = CScriptNum(vch1, true, 5);
 162 | +                } catch (scriptnum_error) {
 163 | +                    break;
 164 | +                }
 165 | +                // 0 CLTV is pointless, so expect at least height 1

jonasschnelli commented at 3:53 PM on February 19, 2016:

Maybe we should keep OP_U32INT independent from CLTV? Allow 0 as value?

jonasschnelli commented at 3:57 PM on February 19, 2016: contributor

Concept ACK.
sipa commented at 6:47 AM on May 17, 2016: member

See also #7601.
luke-jr force-pushed on Oct 15, 2016
Bugfix: wallet: Check nLockTime before deciding an output is spendable fed7d2f19c
Recognise a simple CLTV prefix to multisigs 864c493a3c
Minimal RPC & wallet support for CLTV-enabled multisig addresses bd7178a0e4
luke-jr force-pushed on Oct 15, 2016
luke-jr commented at 7:35 AM on November 12, 2016: member

Closing due to apparent lack of interest... If you want to review, poke me and I'll rebase/reopen...
luke-jr closed this on Nov 12, 2016
nickrowley commented at 6:44 AM on November 15, 2016: none

The concept is great, puts new BIPs to the front, if this could get more interest , could result in developers making easy use of new functionality.
DrahtBot locked this on Aug 16, 2022

Contributors

Labels