Check for EOF before every getline, and warn when reading gets to EOF before the end of the data.
Also check when number of keys does not match number of values.
Stricter error checking could shed more light on issues such as #7463 and #7379.
wallet: Warn on unexpected EOF while salvaging wallet #7537
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_02_salvage_unexpected_eof changing 1 files +19 −3-
laanwj commented at 3:20 PM on February 15, 2016: member
- laanwj added the label Wallet on Feb 15, 2016
-
ca8fb59ae1
wallet: Warn on unexpected EOF while salvaging wallet
Check for EOF before every getline, and warn when reading gets to EOF before the end of the data. Stricter error checking could shed more light on issues such as #7463 and #7379.
- laanwj force-pushed on Feb 15, 2016
-
jonasschnelli commented at 4:04 PM on February 19, 2016: contributor
utACK
-
MarcoFalke commented at 5:42 PM on February 27, 2016: member
utACK ca8fb59
Edit: I got this once now:
2016-02-27 18:15:43 Renamed wallet.dat to wallet.1456596943.bak 2016-02-27 18:15:43 CDBEnv::Salvage: Database salvage found errors, all data may not be recoverable. 2016-02-27 18:15:43 CDBEnv::Salvage: WARNING: Number of keys in data does not match number of values. 2016-02-27 18:15:43 CDBEnv::Salvage: WARNING: Unexpected end of file while reading salvage output. 2016-02-27 18:15:43 Salvage(aggressive) found 300 records - laanwj merged this on Feb 29, 2016
- laanwj closed this on Feb 29, 2016
- laanwj referenced this in commit 78e81b0bc5 on Feb 29, 2016
- codablock referenced this in commit 676c6da4f9 on Sep 16, 2017
- codablock referenced this in commit 97794d17d3 on Sep 19, 2017
- codablock referenced this in commit d0c24450e1 on Dec 9, 2017
- codablock referenced this in commit 8993b02dd3 on Dec 9, 2017
- codablock referenced this in commit 74eda87591 on Dec 11, 2017
- random-zebra referenced this in commit 46fad30bbb on Nov 15, 2020
- DrahtBot locked this on Sep 8, 2021
