Don’t vote for /P2SH/ unless -p2sh specified (and vote against if -p2sh=0) #755
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:explicit_p2sh changing 3 files +11 −1-
luke-jr commented at 5:26 pm on January 13, 2012: memberPlease don’t force people to vote for things they might not want (and shouldn’t).
-
sipa commented at 5:57 pm on January 13, 2012: member
I have no problem with being able to state your opinion about the matter when running the client (even though using the client already implies some form of consent).
However, the coinbase-voting is intended to be a good representation of the mining power behind the proposal. As the current codebase contains the changes stated by BIP 0016, the codebase should provide the vote as well.
IMHO, a -nop2sh is possible that disables both the vote and the behaviour.
-
gavinandresen commented at 7:37 pm on January 18, 2012: contributorEither a -p2sh=1/0 or a -nop2sh=1/0 is OK with me, but not both (what happens if I screw up and specify -p2sh=1 -nop2sh=1 ?)
-
luke-jr commented at 8:47 pm on January 18, 2012: member
I didn’t realize bool args took a parameter ;)
Refactored with -p2sh[=0/1]
-
Don't vote for /P2SH/ unless -p2sh specified (and vote against if -p2sh=0) fbfda529a9
-
jgarzik commented at 10:17 pm on February 3, 2012: contributorI agree w/ sipa: create a “nop2sh” option, which is disabled by default (i.e. p2sh is enabled by default)
-
luke-jr closed this on Feb 17, 2012
-
ptschip referenced this in commit 919d760cc5 on Aug 19, 2017
-
sipa referenced this in commit 67f232b5d8 on Jun 9, 2020
-
sipa referenced this in commit 6be8b194cf on Jun 10, 2020
-
sipa referenced this in commit 767ee3aee4 on Jun 18, 2020
-
stackman27 referenced this in commit 78cde6f8c7 on Jun 26, 2020
-
sipa referenced this in commit b3708b7612 on Jul 19, 2020
-
JeremyRubin referenced this in commit 9905e74e49 on Jul 27, 2020
-
DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 15:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me