Remove vfReachable and modify IsReachable to only use vfLimited. #7553

1. 
   pstratem commented at 6:45 am on February 18, 2016: contributor

   We do not know that a class of Network is reachable, only that it is not.
2. pstratem force-pushed on Feb 18, 2016
3. Remove vfReachable and modify IsReachable to only use vfLimited.

   We do not know that a class of Network is reachable, only that it is not.

   110b62f069
4. laanwj added the label P2P on Feb 18, 2016
5. 
   laanwj commented at 10:04 am on February 18, 2016: member

   Possibly related issue, there’s some discussion there:

   • Addrman only contains seed nodes when there’s no externally bound address #7098 @theuni

   Concept ACK, I don’t think we need both vfLimited and vfReachable, though this will have to be carefully checked to make sure it still respects onlynet, and proxies etc. No automatic tests for any of this.

6. 
   pstratem commented at 10:15 am on February 18, 2016: contributor

   @laanwj Yes this will fix that issue.

   onlynet and proxy settings are unaffected

7. 
   laanwj commented at 9:15 am on February 29, 2016: member

   @theuni can you please take a look here, as you performed investigation in #7098. Do you see problems with this solution?
8. 
   theuni commented at 6:28 pm on March 1, 2016: member

   Concept ack, trying to balance the two was confusing. Quick code review ack as well.
9. 
   sipa commented at 5:20 am on March 5, 2016: member

   Concept ACK
10. laanwj added the label Needs backport on Mar 11, 2016
11. laanwj merged this on Mar 11, 2016
12. laanwj closed this on Mar 11, 2016

    ---

13. laanwj referenced this in commit 9f14e5ad91 on Mar 11, 2016
14. MarcoFalke referenced this in commit 328dbc2b70 on Apr 25, 2016
15. MarcoFalke referenced this in commit a5bc6a1bc4 on Apr 27, 2016
16. 
    MarcoFalke commented at 10:56 am on June 9, 2016: member

    Backported as part of #7938. Removing label ‘Needs backport’.
17. MarcoFalke removed the label Needs backport on Jun 9, 2016
18. thokon00 referenced this in commit 85b0c2ac41 on Jun 28, 2016
19. nomnombtc referenced this in commit 2bb571125c on Nov 12, 2016
20. nomnombtc referenced this in commit 432387181e on Nov 12, 2016
21. nomnombtc referenced this in commit 1aff96d7a8 on Nov 12, 2016
22. nomnombtc referenced this in commit 84150a9486 on Nov 13, 2016
23. nomnombtc referenced this in commit f30df51d66 on Nov 14, 2016
24. sickpig referenced this in commit 98d95ffee7 on Nov 14, 2016
25. zkbot referenced this in commit 45faa928ec on Mar 26, 2017
26. laanwj referenced this in commit 43a79d22c1 on Jan 14, 2019
27. PastaPastaPasta referenced this in commit b8bc9e9643 on Jul 18, 2021
28. PastaPastaPasta referenced this in commit 325aff4094 on Jul 18, 2021
29. DrahtBot locked this on Feb 15, 2022

Contributors
pstratem laanwj theuni sipa MarcoFalke

Labels
P2P