[OSX] fix brew openssl detection #7560

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/02/osx_openssl changing 1 files +2 −0
  1. jonasschnelli commented at 2:06 PM on February 19, 2016: contributor

    ping @theuni (not sure if I did this correct, it seems like extending PKG_CONFIG_PATH does not work for a later header check with AC_CHECK_HEADER).

    OSX slowly depractates openssl. Since 10.11.3, not event Xcode installs the openssl headers. This PR will allow using homebrews openssl headers.

  2. [OSX] fix brew openssl detection a8056b995e
  3. jonasschnelli added the label Mac on Feb 19, 2016
  4. jonasschnelli added the label Build system on Feb 19, 2016
  5. jameshilliard commented at 2:18 AM on February 20, 2016: contributor

    The workaround I've used is:

    brew link openssl --force
    
  6. jonasschnelli commented at 8:07 AM on February 20, 2016: contributor

    The force linking is also a good idea, though, I think if we detect brews OpenSSL pkgconf, we should also allow to detect the headers in brews OpenSSL path.

  7. jameshilliard commented at 8:22 AM on February 20, 2016: contributor

    I think this is how you would do that properly.

  8. jonasschnelli commented at 8:49 AM on February 20, 2016: contributor

    @jameshilliard I think this PR would do it exactly as recommended in you link.

  9. jameshilliard commented at 8:53 AM on February 20, 2016: contributor

    Doesn't it need $(brew --prefix) in the include path for keg only openssl?

  10. laanwj commented at 9:08 AM on February 29, 2016: member

    @theuni can you take a look here?

  11. theuni commented at 6:35 AM on March 1, 2016: member

    @jonasschnelli hmm, appending PKG_CONFIG_PATH should be enough to pick up on the openssl headers (that's what it's there for). In the header check, we first set CFLAGS="$CFLAGS $SSL_CFLAGS $CRYPTO_CFLAGS", which should add whatever pkg-config finds.

    So your change shouldn't be necessary, seems to me something else is broken.

    Could you please paste the relevant failure from config.log?

  12. jonasschnelli commented at 8:00 AM on March 1, 2016: contributor

    Cannot reproduce the issue anymore. It was probably a local-only thing. Thanks @theuni!

  13. jonasschnelli closed this on Mar 1, 2016

  14. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me