libconsensus-p2a: Preparations to decouple libconsensus from coins.o #7564

pull jtimon wants to merge 3 commits into bitcoin:master from jtimon:libconsensus-p2a-coins-cpp-interface-0.12.99 changing 4 files +116 −24
  1. jtimon commented at 1:37 am on February 20, 2016: contributor

    Analogous to #7563 but with coins instead of chain.o Replaces “Refactor: Create CCoinsViewEfficient interface for CCoinsViewCache #5747 [coins]”.

    Unnecessary dependencies:

    • libconsensus-p2a: Decouple pow.o from chain.o and move it to the consensus package #7563 [libconsensus-p2a-chain-cpp-interface-0.12.99]

    This doesn’t need to depend on #7563, but the first commit in both PRs writes the same file.

  2. jtimon force-pushed on Feb 20, 2016
  3. Consensus: Introduce CBlockIndexView in consensus/storage_interfaces_cpp.h 5de72fab60
  4. Consensus: Introduce CCoinsInterface and CUtxoView in consensus/storage_interfaces_cpp.h acc90b77ae
  5. Consensus: Make coins.o implement consensus/storage_interfaces_cpp
    CCoins implements CCoinsInterface
    CCoinsView implements CUtxoView (not fully, but CCoinsViewCache implements the rest)
    b42a5b2ed3
  6. jtimon force-pushed on Feb 20, 2016
  7. jonasschnelli added the label Refactoring on Feb 20, 2016
  8. jtimon commented at 2:29 am on February 26, 2016: contributor

    Closing for now. Will be reopened if #7563 is merged. Review will still be valuable and traceable even if the PR gets replaced in the future (although I hope to just reopen it at some point after 12.1 is released).

    EDIT: Why close then? I had violated my self-imposed policy of no more than 5 open PRs to master at a time.

  9. jtimon closed this on Feb 26, 2016

  10. DrahtBot locked this on Sep 8, 2021


jtimon

Labels
Refactoring


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me