Sample RPM spec file for Bitcoin 0.12.0 #7588

pull AliceWonderMiscreations wants to merge 0 commits into bitcoin:master from AliceWonderMiscreations:master changing 0 files +0 −0
  1. AliceWonderMiscreations commented at 11:12 AM on February 24, 2016: contributor

    RPM is a powerful package management tool used by many distributions. The value of having bitcoin-core in Linux distributions that use RPM should be fairly obvious with the coming SegWit soft-fork and the possible block size hard fork, as it would allow users of distributions that include a Bitcoin RPM to keep up to date automatically.

    Included in this pull request is a sample RPM spec file that "works for me" on CentOS 7 to build Bitcoin 0.12.0 safely using the recommended version of BerkeleyDB statically linked at build time, and running the necessary tests at build time to make sure the build was successful before the packaging succeeds.

  2. AliceWonderMiscreations commented at 11:39 AM on February 24, 2016: contributor

    The failed Travis CI check is a win32 check, not sure what it was trying... this has nothing to do with win32.

  3. laanwj commented at 12:11 PM on February 24, 2016: member

    Yes the travis faliure was unrelated to your changes, looks like a server side issue:

    W: GPG error: http://ppa.launchpad.net precise Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5A9A06AEF9CB8DB0
    5.94s$ if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get install --no-install-recommends --no-upgrade -qq $PACKAGES; fi
    WARNING: The following packages cannot be authenticated!
      liblcms2-2 liblcms2-2 wine1.7-amd64 wine1.7-i386 wine1.7
    E: There are problems and -y was used without --force-yes
    
  4. in contrib/rpm/bitcoin.spec:None in 14baddcb1d outdated
      12 | +Source1:	http://download.oracle.com/berkeley-db/db-%{bdbv}.NC.tar.gz
      13 | +
      14 | +Source10:	https://raw.githubusercontent.com/bitcoin/bitcoin/master/contrib/debian/examples/bitcoin.conf
      15 | +
      16 | +#man pages
      17 | +Source20:	https://raw.githubusercontent.com/bitcoin/bitcoin/master/contrib/debian/manpages/bitcoind.1
    


    btcdrak commented at 1:24 PM on February 24, 2016:

    I am unfamiliar with RPM spec files, but could this be made dynamic according to the release tag? e.g.

    https://raw.githubusercontent.com/bitcoin/bitcoin/v%{version}/contrib/debian/examples/bitcoin.conf


    AliceWonderMiscreations commented at 3:39 PM on February 24, 2016:

    Oh I think I see what you mean, yes I think that could be done.


    btcdrak commented at 3:43 PM on February 24, 2016:
  5. AliceWonderMiscreations commented at 1:33 PM on February 24, 2016: contributor

    @btcdrak you can make a bitcoin.spec.in that has the current version created by the autoconf stuff when it creates bitcoin.spec but that practice is discouraged because there is no way to accurately track changes in the changelog then.

  6. laanwj added the label Build system on Feb 24, 2016
  7. AliceWonderMiscreations commented at 2:03 AM on February 25, 2016: contributor

    I seem to be having trouble figuring out how to squash, all the docs seem to assume the reader is familiar with some concept I am not.

    [alice@localhost bitcoin]$ git remote -v
    AliceWonder https://github.com/AliceWonderMiscreations/bitcoin.git (fetch)
    AliceWonder https://github.com/AliceWonderMiscreations/bitcoin.git (push)
    origin  https://github.com/bitcoin/bitcoin.git (fetch)
    origin  https://github.com/bitcoin/bitcoin.git (push)
    [alice@localhost bitcoin]$ git branch -v
    * AliceWonder 3174621 Merge [#7583](/bitcoin-bitcoin/7583/): [doc] Fix typos
      master      3174621 Merge [#7583](/bitcoin-bitcoin/7583/): [doc] Fix typos
    [alice@localhost bitcoin]$
    

    But it's not even showing the files I have modified, nor fetching them, no way to do a squash.

    I'ts not worth my time to try and figure it out, I've wasted hours on it, I'm sure it is simple and I'm just a n00b that doesn't know what the dozen or so pages I have looked at assumes the reader knows.

    So sorry, I can't squash.

  8. AliceWonderMiscreations commented at 3:29 AM on February 25, 2016: contributor
    git pull AliceWonder -u master
    git checkout master
    git merge --squash AliceWonder
    git commit
    

    seems to have worked but I can't seem to make that appear here.

  9. AliceWonderMiscreations closed this on Feb 25, 2016

  10. AliceWonderMiscreations commented at 3:53 AM on February 25, 2016: contributor

    I will try again as a single pull request.

  11. AliceWonderMiscreations commented at 10:45 AM on February 25, 2016: contributor

    @laanwj @MarcoFalke I am going to wait until 0.12.1

    At that point, the patch won't be needed for LibreSSL builds and at that point maybe I won't need to specify qt4 to configure and maybe at that point I'll have qt5 for RHEL/CentOS 7 working anyway from the Qt packages in EPEL.

    So I will keep tweaking the spec file on my end but wait until 0.12.1 to try and do a pull request.

    I also now have SELinux in my spec file on my own system, but I want to study it more to make damn sure it really is right.

  12. AliceWonderMiscreations commented at 2:25 PM on February 26, 2016: contributor

    Okay I am going to re-open this after having done considerable work to make the spec file better.

    It now defaults to qt5 but allows specifying qt4 or no GUI at build time. And it has SELinux stuff for the bitcoin-server package.

    I would appreciate comments on anything that still needs tweaking before I try to do the squash.

  13. AliceWonderMiscreations reopened this on Feb 26, 2016

  14. AliceWonderMiscreations commented at 5:06 PM on February 26, 2016: contributor

    Gah I thought I had the squash thing figured out but I clearly don't, and now it is showing a few commits from other people that aren't related to this.

    https://github.com/AliceWonderMiscreations/bitcoin/commit/0b8bda70a22a2474d4c1d0c3a279dd2196fe3d5e - how did my name get into that?

  15. btcdrak commented at 5:19 PM on February 26, 2016: contributor

    @AliceWonderMiscreations fwiw, squashing the merge commits is a pain. It might be easier to just copy the changed files, reset the tree and paste them back :-)

  16. AliceWonderMiscreations closed this on Feb 26, 2016

  17. AliceWonderMiscreations commented at 5:38 PM on February 26, 2016: contributor

    @btcdrak Thank you - #7609

  18. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me