mempool: Re-remove ERROR logging for mempool rejects #7592

1. 
   laanwj commented at 6:37 PM on February 24, 2016: member

   Continues "Make logging for validation optional" from #6519.

   The idea there was to remove all ERROR logging of rejected transaction, and move it to one message in the class 'mempoolrej' which logs the state message (and debug info). The superfluous ERRORs in the log "terrify" users, see for example issue #5794.

   Unfortunately a lot of new logging was introduced in #6871 (RBF) and #7287 (misc refactoring) without taking this into account, for example:

   2016-02-24 18:28:45 ERROR: AcceptToMemoryPoolWorker: CheckInputs: ae5ca485da7464f211aa314c37f6c7c5a1807807dc448cba187bce0c214e8853, non-mandatory-script-verify-flag (Non-canonical signature: S value is unnecessarily high) (code 64)
   

   This pull updates that new code.

2. laanwj added the label P2P on Feb 24, 2016
3. laanwj added the label Mempool on Feb 24, 2016
4. mempool: Reduce ERROR logging for mempool rejects

   Continues "Make logging for validation optional" from #6519.
   
   The idea there was to remove all ERROR logging of rejected transaction,
   and move it to one message in the class 'mempoolrej' which logs the
   state message (and debug info). The superfluous ERRORs in the log
   "terrify" users, see for example issue #5794.
   
   Unfortunately a lot of new logging was introduced in #6871 (RBF) and
    #7287 (misc refactoring). This pull updates that new code.

   8fc81e0983
5. laanwj force-pushed on Feb 24, 2016
6. laanwj renamed this:
   mempool: Reduce ERROR logging for mempool rejects
   mempool: Re-remove ERROR logging for mempool rejects
   on Feb 29, 2016
7. 
   sipa commented at 5:40 AM on March 5, 2016: member

   utACK

8. 
   jtimon commented at 10:57 AM on March 5, 2016: contributor

   UtACK

9. 
   paveljanik commented at 11:15 AM on March 5, 2016: contributor

   ACK

10. laanwj added the label Needs backport on Mar 11, 2016
11. laanwj merged this on Mar 11, 2016
12. laanwj closed this on Mar 11, 2016

    ---

13. laanwj referenced this in commit 26a2a7214f on Mar 11, 2016
14. laanwj removed the label Needs backport on Sep 26, 2016
15. laanwj added this to the milestone 0.12.2 on Sep 26, 2016
16. laanwj added the label Needs backport on Sep 26, 2016
17. codablock referenced this in commit df92e0f6c5 on Sep 16, 2017
18. codablock referenced this in commit 1135fea46a on Sep 19, 2017
19. codablock referenced this in commit fc631c19f7 on Dec 9, 2017
20. codablock referenced this in commit 24cf36972c on Dec 19, 2017
21. fanquake removed the label Needs backport on Mar 7, 2018
22. MarkLTZ referenced this in commit 3977804911 on Apr 27, 2019
23. MarcoFalke locked this on Sep 8, 2021

Contributors

laanwjsipajtimonpaveljanik

Milestone
0.12.branch