[WIP] [RPC] Add call zaptransaction to delete transaction from wallet #7602

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:zaponetx changing 5 files +102 −0
  1. instagibbs commented at 9:41 PM on February 25, 2016: member

    No tests yet, looking for concept ACKs, or to see what people would want for this.

    It's essentially mirror functionality of #7558.

    I am not sure how mempool interacts with this(I'm guessing I should check if it's in block/mempool like abandontransaction does) but the usage is intended for in-block transactions.

  2. Add rpc call zaptransaction to delete transaction from wallet without rescan. 23c87dfa2f
  3. jonasschnelli added the label Wallet on Feb 25, 2016
  4. laanwj commented at 8:48 AM on February 29, 2016: member

    I think the idea behind abandontransaction as introduced in 0.12 (#7312) was to provide this functionality in a safer way. Deleting anything permanently from the db shouldn't be done lightly. Ping @morcos

  5. instagibbs commented at 9:58 PM on February 29, 2016: member

    While similar, this functionality is more meant to pair with #7558, which isn't applicable to abandontransaction. If you have a transaction in your wallet that is confirmed, yet you do not want to "account for" as having the funds, there isn't a way to do this. Primarily I think this could happen for instance with an erroneous application of #7558 .

  6. laanwj commented at 1:07 PM on March 2, 2016: member

    I understand the application is different, but there's a risk in having vaguely similar functionality in different RPC calls. Before adding abandontransaction we had a long discussion about what would be safe as well versus unsafe RPC call behavior for this purpose, so it already is a compromise.

    Idea: If it is meant as antidote to #7558, why not call it removeprunedfunds and make it only work on funds thus added?

  7. instagibbs commented at 2:56 PM on March 2, 2016: member

    Understood and agreed. I might want to merge the two PRs then, and tag transactions in such a way to ensure that property.

  8. morcos commented at 5:52 PM on March 2, 2016: member

    I don't have a strong opinion about this functionality. I do think it is quite different from abandontransaction though

  9. laanwj commented at 1:18 PM on March 3, 2016: member

    Well if really they're sufficiently different hat people won't get confused, I'm ok with adding this... But based on the names at least I would get confused as API user, I think. But that may be a documentation issue.

  10. instagibbs commented at 1:48 PM on March 7, 2016: member

    Closing in favor of merging the two PRs, with more aligned names and description.

  11. instagibbs closed this on Mar 7, 2016

  12. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me