[doc/log] Fix markdown syntax and line terminate LogPrint #7617

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:Mf1602-trivial9 changing 9 files +12 −16

MarcoFalke commented at 5:21 PM on February 27, 2016: member
- Fix three minor issues in the 0.12 historical release notes.
- Fix some links
- Yet another #6497
Fix doxygen comment for payTxFee fa06ce0949
jonasschnelli added the label Docs and Output on Feb 28, 2016
MarcoFalke force-pushed on Feb 28, 2016
MarcoFalke force-pushed on Feb 28, 2016
MarcoFalke force-pushed on Feb 28, 2016
MarcoFalke renamed this:
~~[doc] Minor corrections to release notes and links~~
[doc/log] Fix markdown syntax and line terminate LogPrint
on Feb 28, 2016
MarcoFalke force-pushed on Feb 28, 2016

in doc/release-notes/release-notes-0.12.0.md:None in fa100ecb97 outdated

 700 | @@ -701,7 +701,7 @@ git merge commit are mentioned.
 701 |  - #7112 `96b8025` reduce cs_main locks during tip update, more fluently update UI (Jonas Schnelli)
 702 |  - #7206 `f43c2f9` Add "NODE_BLOOM" to guiutil so that peers don't get UNKNOWN[4] (Matt Corallo)
 703 |  - #7282 `5cadf3e` fix coincontrol update issue when deleting a send coins entry (Jonas Schnelli)
 704 | -- #7319 `1320300` Intro: Display required space (Jonas Schnelli)
 705 | +- #7319 `1320300` Intro: Display required space (MarcoFalke)

laanwj commented at 8:03 AM on February 29, 2016:

Oops, yes, this was a backport

laanwj commented at 8:04 AM on February 29, 2016: member

ACK fa100ec
jonasschnelli commented at 9:02 AM on February 29, 2016: contributor

ACK fa100ecb9795fe4a6c4a0f928fc8e9858e979303
btcdrak commented at 9:10 AM on February 29, 2016: contributor

ACK
laanwj commented at 10:21 AM on February 29, 2016: member

Tangential: Would be awesome to have a lint-er that checked these kinds of things: LogPrint[f]/strprintf number of arguments versus number of %, line breaks (although there are cases where you explicitly don't want them, but I they could be marked insome way).
[doc] Fix markdown fa97f95c15
in src/net.cpp:None in fa100ecb97 outdated
```
2469 | @@ -2470,7 +2470,7 @@ void CNode::BeginMessage(const char* pszCommand) EXCLUSIVE_LOCK_FUNCTION(cs_vSen
2470 |      ENTER_CRITICAL_SECTION(cs_vSend);
2471 |      assert(ssSend.size() == 0);
2472 |      ssSend << CMessageHeader(Params().MessageStart(), pszCommand, 0);
2473 | -    LogPrint("net", "sending: %s ", SanitizeString(pszCommand));
2474 | +    LogPrint("net", "sending: %s\n", SanitizeString(pszCommand));
```
laanwj commented at 1:22 PM on March 1, 2016:

Are you sure this is correct? I think this was supposed to be un-terminated, because other message-related commands continue the logging.

MarcoFalke commented at 1:40 PM on March 1, 2016:

I remember I saw at least one instance which was wrong but I can't recall which one as I have deleted the debug.log in the meantime. I have reverted for now and will look into this later.
MarcoFalke force-pushed on Mar 1, 2016
Make sure LogPrintf strings are line-terminated fa26652459
MarcoFalke force-pushed on Mar 1, 2016
laanwj merged this on Mar 1, 2016
laanwj closed this on Mar 1, 2016
laanwj referenced this in commit e5121eb951 on Mar 1, 2016
MarcoFalke deleted the branch on Mar 1, 2016
laanwj referenced this in commit f04f4fd2ee on Mar 11, 2016
zander referenced this in commit cbffcf06e7 on Apr 22, 2016
zkbot referenced this in commit 8713d73daf on Dec 18, 2019
zkbot referenced this in commit 2da77edbfe on Dec 18, 2019
zkbot referenced this in commit 577f7ef72a on Dec 18, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6497 Make sure LogPrintf strings are line-terminated #7666 [0.12.1] Fix doc and output for rpcauth