Bugfix: Check for bench_bitcoin being enabled where needed, and skip UniValue dependency when unused #7625

pull luke-jr wants to merge 5 commits into bitcoin:master from luke-jr:bugfix_bench_checks changing 4 files +41 −15

luke-jr commented at 2:16 PM on March 1, 2016: member

No description provided.
configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx 2b66034f19
Merge branch 'separate_utils-0.10.x' into separate_utils aca0433e41
Merge branch 'separate_utils-0.11.x' into separate_utils b81ce0bb10
Merge branch 'master' into bugfix_bench_checks 5e8b81b2db
Bugfix: Check for bench_bitcoin being enabled where needed, and skip UniValue dependency when unused 789200f22b
laanwj commented at 2:22 PM on March 1, 2016: member

This seems to import all kinds of ancillary changes?
laanwj added the label Build system on Mar 1, 2016
luke-jr commented at 2:43 PM on March 1, 2016: member

Yes, it's based on #5618. The cost of continually rebasing things like this without it seems higher than the cost of just merging it...
laanwj commented at 3:06 PM on March 1, 2016: member

That's fine but a) You should at least list all the changes that you make in the PR description b) Some of these have been rejected before, sometimes multiple times, such as having a configuration option for every single utility.
kirkalx commented at 2:47 AM on March 2, 2016: contributor

Not relevant to Luke's PR but this sort of thing "xnononononono", looks like it would be easy to screw up. Any good reason for it?
luke-jr commented at 1:31 PM on March 2, 2016: member

Lack of a better alternative?
laanwj commented at 1:58 PM on March 2, 2016: member

@kirkalx I commented on that too when that was introduced, but apparently that's the portable shell script way of doing things. Blame silly 80's UNIX's inheritance.
laanwj commented at 9:41 AM on April 19, 2016: member

I think this is too messy with all the merges factored in, closing.
laanwj closed this on Apr 19, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels