QT: Add 'copy full transaction details' option #7628

pull ghost wants to merge 1 commits into bitcoin:master from changing 4 files +41 −6

ghost commented at 7:18 PM on March 1, 2016: none

Adds feature from issue #7484
ghost commented at 8:20 PM on March 1, 2016: none

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

That's a bit odd. My pull request compiled fine on every other job in the Travis CI build... so I'm not sure what to make of this.
MarcoFalke commented at 8:25 PM on March 1, 2016: member

No worries, it is a know issue unrelated to your changes.
ghost commented at 10:19 PM on March 1, 2016: none

ah, I see. what a relief
jonasschnelli added the label GUI on Mar 2, 2016
laanwj commented at 12:56 PM on March 2, 2016: member

Restarted travis, it should pass now.

paveljanik commented at 7:24 AM on March 3, 2016: contributor

ACK https://github.com/ericshawlinux/bitcoin/commit/fff0dcc4a42f384fa9e7778fa0241f3448454658

Minor NIT: empty '()' on addresses without labels. Can be tested beforehand...

For unconfirmed transaction:

3/3/16 08:05 Unconfirmed () mjHi7MpmjKzez9KY8zL6sSQVtBpqsaB9LF 2.60000000

4 confirms:

3/3/16 08:05 Confirming (4 of 6 recommended confirmations) () mjHi7MpmjKzez9KY8zL6sSQVtBpqsaB9LF 2.60000000

Confirmed:

3/3/16 08:05 Confirmed (6 confirmations) () mjHi7MpmjKzez9KY8zL6sSQVtBpqsaB9LF 2.60000000

With label:

3/3/16 08:05 Confirmed (6 confirmations) (Test label for [#7628](/bitcoin-bitcoin/7628/)) mjHi7MpmjKzez9KY8zL6sSQVtBpqsaB9LF 2.60000000

The debug log contains this on OS X (the same warning as with Copy raw transaction:

2016-03-03 07:10:46 GUI: Data set on unsupported clipboard mode. QMimeData object will be deleted.

paveljanik commented at 7:33 AM on March 3, 2016: contributor

Off-topic here, but anyway: it would be nice to be able to add label to the address directly from the main window, in Recent transactions.

in src/qt/transactiontablemodel.cpp:None in fff0dcc4a4 outdated

 616 | +
 617 | +            details.append(date.toString("M/d/yy HH:mm"));
 618 | +            details.append(" ");
 619 | +            details.append(formatTxStatus(rec));
 620 | +            details.append(" (");
 621 | +            details.append(walletModel->getAddressTableModel()->labelForAddress(QString::fromStdString(rec->address)));

jonasschnelli commented at 12:19 PM on March 3, 2016:

nit: what about only append L620 to L622 if !rec->address.empty()? I guess most users have couple of transaction without according address labels.

jonasschnelli commented at 12:34 PM on March 3, 2016: contributor
Tested ACK modulo nit.

Agree with @paveljanik about the () and the warning. Although the console-out warning is unrelated to this PR. If it can be fixed, it could be done in a different PR.

Binaries: https://bitcoin.jonasschnelli.ch/pulls/7628/

4 Examples
```
3/3/16 13:19 Unconfirmed ()  -0.00003840
3/3/16 13:24 Unconfirmed (Yes! A testlabel.) mgY7FaksgbtrNPVJKzJBrKTG3Ayfqddc8R -1.00003840
2/22/16 09:27 Immature (6 confirmations, will be available after 101) () mr5C9MyoswwkTzFzwys6LfS5TdrX6u8xRo 0.39062500
2/22/16 09:27 Confirmed (143 confirmations) () mr5C9MyoswwkTzFzwys6LfS5TdrX6u8xRo 0.78125000
```
Two conceptual ideas for further improvements:
1. Would adding the transaction type make sense? In/Out/Mined? Or is the +/- in the balance enough, at least coinbase transaction are indistinguishable against "other" incoming txes?
2. If I select a row and hit Ctrl-C, currently, it does copy the cell-content I have last clicked (only date or only type, etc.). I think it would be nice to copy the "full details" if one presses Ctrl-C while having a row selected.

in src/qt/transactiontablemodel.cpp:None in 3a7c65885d outdated

 623 | +                details.append(formatTxType(rec));
 624 | +                details.append(" ");
 625 | +            }
 626 | +            if(!rec->address.empty()) {
 627 | +                if(txLabel.isEmpty())
 628 | +                    details.append("(no label) ");

jonasschnelli commented at 9:06 PM on March 6, 2016:

We should use details.append(tr("(no label)")+" "); here to allow translations.

jonasschnelli commented at 9:06 PM on March 6, 2016: contributor

Can you squash your commits?
ghost commented at 3:12 AM on March 7, 2016: none

Ok

QT: Add 'copy full transaction details' option

Adds feature from issue #7484

modifies the ctrl-c binding to copy full transaction details in transaction view.

Added translation

b51ed4036e

jonasschnelli commented at 9:14 AM on March 8, 2016: contributor

Tested ACK b51ed4036e157a116414f53ac8da78c6b35bf041.
jonasschnelli merged this on Mar 8, 2016
jonasschnelli closed this on Mar 8, 2016
jonasschnelli referenced this in commit 87d6562299 on Mar 8, 2016
codablock referenced this in commit 4aff44724b on Sep 5, 2017
codablock referenced this in commit 1448da526c on Sep 5, 2017
UdjinM6 referenced this in commit 690cb58f80 on Sep 7, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7484 feature request: bitcoin-qt gui - transactions list - right click menu - copy full details