Order CTxMemPool::queryHashes result by feerate including descendents. #7629

pull pstratem wants to merge 1 commits into bitcoin:master from pstratem:2016-03-01-queryhashes changing 1 files +1 −1

pstratem commented at 10:10 PM on March 1, 2016: contributor

No description provided.
pstratem force-pushed on Mar 1, 2016
sdaftuar commented at 10:12 PM on March 1, 2016: member

Motivation? Curious whether whatever you're using this for should be using descendant fee rate or ancestor fee rate (see #7594)...
pstratem force-pushed on Mar 1, 2016
pstratem commented at 10:17 PM on March 1, 2016: contributor

@sdaftuar the motivation is two part

first to ensure mempool walks are in an order which avoids any orphans

second to make the feefilter command more efficient in combination with the mempool p2p command
Order CTxMemPool::queryHashes result by feerate including descendents. 0a94cf6e03
pstratem commented at 10:33 PM on March 1, 2016: contributor

@sdaftuar is right this should be using ancestor indexing
laanwj added the label Mempool on Mar 3, 2016
sipa commented at 5:13 AM on March 5, 2016: member

@pstratem Can you elaborate? How does this guarantee the avoidance of orphans? Transaction descendants can have both higher or lower feerate than the parent.
pstratem commented at 8:21 AM on March 5, 2016: contributor

@sipa it doesn't i mis understood what was being indexed.

i'll fix this properly later
pstratem closed this on Mar 5, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels