Fix memleak in TorController [rework] #7637

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_03_torcontrol_leak changing 1 files +9 −4

laanwj commented at 12:31 PM on March 3, 2016: member

It looks like, TorController::disconnected_cb(TorControlConnection& conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and deleting it only once in the destructor (thanks to Cory Fields for the idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Fix memleak in TorController [rework]

It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

e219503711

laanwj added the label P2P on Mar 3, 2016
laanwj added the label Needs backport on Mar 3, 2016
jonasschnelli commented at 12:32 PM on March 3, 2016: contributor

utACK.
laanwj added the label Resource usage on Mar 3, 2016
theuni commented at 7:54 PM on March 4, 2016: member

ut ACK
laanwj merged this on Mar 11, 2016
laanwj closed this on Mar 11, 2016
laanwj referenced this in commit 3da5d1bc2e on Mar 11, 2016
MarcoFalke referenced this in commit 4eb70a1816 on Apr 25, 2016
MarcoFalke referenced this in commit 66d5408559 on Apr 27, 2016
MarcoFalke commented at 10:57 AM on June 9, 2016: member

Backported as part of #7938. Removing label 'Needs backport'.
MarcoFalke removed the label Needs backport on Jun 9, 2016
thokon00 referenced this in commit da87b1ca6a on Jun 28, 2016
sickpig referenced this in commit 1a43fa56ae on Nov 14, 2016
zkbot referenced this in commit 45faa928ec on Mar 26, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7610 Fix memleak in TorController