Avoid "Unknown command" messages when receiving getaddr on outbound c… #7642

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:GetAddrUnknownCommand changing 1 files +11 −6

rebroad commented at 2:36 PM on March 4, 2016: contributor

…onnections.

Replaces #6344 and addresses concerns raised (i.e. now logs this exceptional event).
rebroad force-pushed on Mar 4, 2016
sipa commented at 3:48 AM on March 5, 2016: member

utACK

Tiny nit: can you use a less wide commit title? See http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for example.
jonasschnelli added the label Refactoring on Mar 6, 2016
laanwj commented at 3:26 PM on March 7, 2016: member

utACK https://github.com/rebroad/bitcoin/commit/d84ea1a59ce3704457a162f1fd8a7353047156de
MarcoFalke commented at 4:57 PM on March 7, 2016: member

utACK d84ea1a
kirkalx commented at 9:40 PM on March 7, 2016: contributor
utACK. Was looking at this code recently @rebroad and as I recall there were a few other similar situations there if you are looking for some more cleanups. Otherwise I'll put it on my TODO list :)

e.g.
```
    else if (strCommand == NetMsgType::HEADERS && !fImporting && !fReindex) // Ignore headers received while importing
```
No "Unknown command" for getaddr command. 9988554fc7
rebroad force-pushed on Mar 8, 2016
rebroad commented at 8:51 AM on March 8, 2016: contributor

@sipa commit reworded
sipa merged this on Mar 9, 2016
sipa closed this on Mar 9, 2016
sipa referenced this in commit c8d2473e6c on Mar 9, 2016
MarcoFalke commented at 12:36 AM on March 14, 2016: member

Could be tagged with "Needs backport"
laanwj added the label Needs backport on Mar 14, 2016
MarcoFalke referenced this in commit c282118812 on Apr 25, 2016
MarcoFalke referenced this in commit d3ead9bcb6 on Apr 27, 2016
MarcoFalke commented at 10:55 AM on June 9, 2016: member

Backported as part of #7938. Removing label 'Needs backport'.
MarcoFalke removed the label Needs backport on Jun 9, 2016
thokon00 referenced this in commit 43111e719b on Jun 28, 2016
nomnombtc referenced this in commit a654022228 on Nov 12, 2016
nomnombtc referenced this in commit 61c6626716 on Nov 12, 2016
nomnombtc referenced this in commit 2e31b59354 on Nov 13, 2016
sickpig referenced this in commit 902851423f on Nov 14, 2016
Astrych referenced this in commit e4d56683a8 on Jan 16, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6344 Avoid "Unknown command" messages when receiving getaddr on outbound c…