Fix lockunspent help message #7646

pull promag wants to merge 1 commits into bitcoin:master from uphold:support/fix-lockunspent-help-message changing 1 files +3 −2

promag commented at 11:55 PM on March 4, 2016: member

Current implementation allows the second parameter to be optional. In that case, and if unlock is true, all locked coins are unlocked.
sipa commented at 3:33 AM on March 5, 2016: member

utACK
jonasschnelli added the label Wallet on Mar 6, 2016
jonasschnelli commented at 3:16 AM on March 6, 2016: contributor

utACK
promag renamed this:
~~Fix lockunspents help message~~
Fix lockunspent help message
on Mar 6, 2016
MarcoFalke commented at 1:01 PM on March 6, 2016: member

utACK cf23442

in src/wallet/rpcwallet.cpp:None in cf23442b29 outdated

2139 |  
2140 | -    if (params.size() == 1)
2141 | -        RPCTypeCheck(params, boost::assign::list_of(UniValue::VBOOL));
2142 | -    else
2143 | -        RPCTypeCheck(params, boost::assign::list_of(UniValue::VBOOL)(UniValue::VARR));
2144 | +    RPCTypeCheck(params, boost::assign::list_of(UniValue::VBOOL)(UniValue::VARR), true);

laanwj commented at 6:06 PM on March 7, 2016:

This is not correct, I think. Setting fAllowNull to true is different to allowing one or two arguments.

laanwj commented at 2:19 PM on March 23, 2016: member

Can you change this to just modify the help message, as the title implies?
promag force-pushed on Mar 23, 2016
Fix lockunspents help message df9e9233dc
promag force-pushed on Mar 23, 2016
promag commented at 3:45 PM on March 23, 2016: member

@laanwj fixed and rebased.
laanwj merged this on Mar 23, 2016
laanwj closed this on Mar 23, 2016
laanwj referenced this in commit e5c35119e9 on Mar 23, 2016
codablock referenced this in commit 9618fc40fe on Sep 16, 2017
codablock referenced this in commit c3f38068b4 on Sep 19, 2017
codablock referenced this in commit 7653c7f9ae on Dec 9, 2017
codablock referenced this in commit a4911c383b on Dec 19, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels