Only need to subtract 1 (originally nNow was in seconds). #7651

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:AskforTime changing 1 files +1 −1

rebroad commented at 10:38 AM on March 8, 2016: contributor

This pull is is a minor nitpick.

When the variable went from seconds to microseconds, this number didn't need to change from 1 to 10,000. It was enough to subtract 1 in order not to reuse time indexes. Perhaps, since moving to microseconds, there may not need to be any subtraction, but for safety, keeping this in.

Replaces #4828
Only need to subtract 1 (originally time was in seconds). 0cd2972eba
rebroad renamed this:
~~Only need to subtract 1 (originally time was in seconds).~~
Only need to subtract 1 (originally nNow was in seconds).
on Mar 8, 2016
jonasschnelli added the label P2P on Mar 8, 2016
sipa commented at 8:48 PM on March 9, 2016: member

ACK
laanwj commented at 7:28 AM on March 11, 2016: member

What is the effect of this in practice?
laanwj commented at 5:06 AM on April 2, 2016: member

I don't think the questions in the source issue (#4828) have been answered satisfactory:

Can you also add a comment to explain why the -1 is there to begin with?

I used to understand why the -1 was there long ago, but I've lost the memory of why it was needed now... I'd have to relook at the code from years ago to work it out.

If no one understands this code, then changing it for nitpicking (essentially aesthetic) reasons is not acceptable to me. This would need a deeper reason to change it. Closing.
laanwj closed this on Apr 2, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels