Add net2 debug option #7654

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:DebugNet2 changing 3 files +6 −6

rebroad commented at 4:08 PM on March 8, 2016: contributor

I often want to enable net debugging, but currently it's too noisy for what I want. Move some of the more verbose net debugging messages to "net2", making "net" debugging more likely to be desired without being too verbose (like this description!).
Add net2 debug option 7356ed39ab
jonasschnelli added the label P2P on Mar 9, 2016
jonasschnelli added the label Priority Low on Mar 9, 2016
jonasschnelli commented at 7:39 AM on March 9, 2016: contributor

I think this makes sense. Although it would remove certain log output if people continue to use only debug=net. But IMO thats okay. I personally would prefer something like debug=netverbose instead of net2.
laanwj commented at 7:45 AM on March 11, 2016: member

I personally would prefer something like debug=netverbose instead of net2.

Agreed
paveljanik commented at 9:26 PM on March 11, 2016: contributor

Concent ACK. I too prefer netverbose.
laanwj commented at 5:30 PM on March 18, 2016: member

@rebroad can you please update the name of the debug category, then we can get this merged.
morcos commented at 2:23 PM on March 22, 2016: member

LogPrint("net", "dropmessages DROPPING SEND MESSAGE\n"); at line 2492 should probably also be moved to the new category.

Also maybe out of scope for this PR but the debug logging around "received getdata" seems due for a cleanup.
laanwj commented at 4:58 AM on April 2, 2016: member

Ping @rebroad
laanwj commented at 4:07 PM on April 5, 2016: member

Closing due to inactivity.
laanwj closed this on Apr 5, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels