[qt] Add .clang-format #7655

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1603-qt-clang-format-0.12 changing 1 files +52 −0

MarcoFalke commented at 6:43 PM on March 8, 2016: member
@jonasschnelli @laanwj Do you think this is useful?

It is pretty much a copy of the existing file with the only diff:
```
--- src/.clang-format
+++ src/qt/.clang-format
@@ -15 +15 @@
-BreakBeforeBraces: Linux
+BreakBeforeBraces: Allman
```
[qt] Add .clang-format faa8bac8c8
jonasschnelli added the label GUI on Mar 9, 2016
jonasschnelli commented at 7:36 AM on March 9, 2016: contributor

No real opinion on that. I just think one clang-format file should be enough.
paveljanik commented at 7:40 AM on March 9, 2016: contributor

@jonasschnelli At first, I had the same opinion as you. At the second look, we should start somewhere. Qt/GUI part is more conservative as the rest of the code, so it will be a good start to put and test the clang-format there.
MarcoFalke commented at 9:19 AM on March 9, 2016: member

I just think one clang-format file should be enough.

So we are not going to keep the current formatting in /qt and /qt is going to accept the formatting of core?
laanwj commented at 7:33 AM on March 11, 2016: member

Due to the undesirability of breaking patches I'm not going to go along with any clang-reformat of the code at large. It's not worth spending too much time on this, there are much larger concerns.

It may make sense to add this for new code though. No strong opinion for or against adding this particular file.
MarcoFalke commented at 8:35 AM on March 12, 2016: member

No strong opinion for or against adding this particular file.

I think everyone is ok with either option. I'd just prefer to know what style is targeted for new code or what I should advise others to do in case they ask for feedback. No need to have a lengthy discussion about this, just express your decision by merging/closing this pull.
laanwj commented at 10:58 AM on March 14, 2016: member

I think the best option is to target one (project global) style only for new code. Anything else is too much unnecessary complication for contributors.

However when adding code to current files it makes sense to use the style used there.
MarcoFalke commented at 11:06 AM on March 14, 2016: member

Ok, great. Then this pull can be closed, I guess.
laanwj closed this on Mar 14, 2016
MarcoFalke deleted the branch on Mar 14, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels