Add curl to Gitian setup instructions #7658

pull btcdrak wants to merge 1 commits into bitcoin:master from btcdrak:curl changing 1 files +1 −1

btcdrak commented at 9:21 AM on March 9, 2016: contributor

curl is required to fetch dependencies

requires backport to all branches

[ci skip]

Add curl to Gitian setup instrustions

curl is required to fetch dependencies

[ci skip]

ce41cf082c

MarcoFalke commented at 9:38 AM on March 9, 2016: member

ACK
luke-jr commented at 3:27 PM on March 9, 2016: member

The gitian descriptors should be installing this now, although I suppose this saves time.
MarcoFalke commented at 3:38 PM on March 9, 2016: member

As I understand this, they are only installed on the guest system: https://github.com/devrandom/gitian-builder/blob/bb4f92f6cbde6ee78e39ae35b0934da3b55e154d/bin/gbuild#L97

So this pull seems like a good place to revert #7614?
luke-jr commented at 3:53 PM on March 9, 2016: member

They're only needed on the guest system.
jonasschnelli added the label Build system on Mar 9, 2016
MarcoFalke commented at 5:13 PM on March 9, 2016: member

They're only needed on the guest system.

Then I fail to see why this pull "requires backport to all branches" considering that Debian is the host system.

Edit: I see, it's required for the optional step in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories
btcdrak commented at 5:22 PM on March 9, 2016: contributor

Without this patch, make -C depends/... command fails to download the dependencies required for gitian builds.
luke-jr commented at 5:49 PM on March 9, 2016: member

@btcdrak But make -C depends/... is not part of the setup instructions... and inside the gitian environment curl is installed by the packages list.
btcdrak commented at 11:15 PM on March 9, 2016: contributor

@luke-jr It is required for this https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#optional-seed-the-gitian-sources-cache-and-offline-git-repositories
laanwj renamed this:
~~Add curl to Gitian setup instrustions~~
Add curl to Gitian setup instructions
on Mar 11, 2016
laanwj added the label Needs backport on Mar 14, 2016
laanwj merged this on Mar 14, 2016
laanwj closed this on Mar 14, 2016
laanwj referenced this in commit c15eb28241 on Mar 14, 2016
btcdrak deleted the branch on Mar 14, 2016
MarcoFalke referenced this in commit bcf71315d6 on Apr 25, 2016
MarcoFalke referenced this in commit 5583a3d0a7 on Apr 27, 2016
MarcoFalke commented at 10:57 AM on June 9, 2016: member

Backported as part of #7938. Removing label 'Needs backport'.
MarcoFalke removed the label Needs backport on Jun 9, 2016
thokon00 referenced this in commit ef2d8358bc on Jun 28, 2016
nomnombtc referenced this in commit 664c1bf74b on Nov 12, 2016
nomnombtc referenced this in commit ced87b5fe2 on Nov 12, 2016
nomnombtc referenced this in commit 689578f8b3 on Nov 13, 2016
sickpig referenced this in commit ab9477e36b on Nov 14, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels