Move GetTempPath() to testutil #7667

pull musalbas wants to merge 2 commits into bitcoin:master from musalbas:patch-gettemppath changing 7 files +53 −25

musalbas commented at 1:13 PM on March 11, 2016: contributor

Addresses #6702 and #6701.

This pull request creates a new source file for test utils, and moves GetTempPath() from util to testutil.

This is because per the above issues, GetTempPath() is insecure and has unchecked error conditions, making it unsuitable for use in production code. GetTempPath() is only used in the unit tests and not used anywhere in the main code, so it would be a good idea to move this to the test suite so that no one tries to use this in the future and it's not mixed with production code.
Add a source file for unit test utils. 393b22eacb
jonasschnelli commented at 1:17 PM on March 11, 2016: contributor

Nice! utACK.
jonasschnelli added the label Tests on Mar 11, 2016
Move GetTempPath() to testutil. 2fdaa25529
musalbas force-pushed on Mar 11, 2016
musalbas commented at 3:30 PM on March 11, 2016: contributor

Fixed Windows build error. The build passes now.
paveljanik commented at 7:13 PM on March 11, 2016: contributor

ACK
MarcoFalke commented at 7:22 PM on March 11, 2016: member

utACK 2fdaa25
laanwj commented at 10:18 AM on March 14, 2016: member

Yes, makes sense, utACK 2fdaa25
laanwj merged this on Mar 14, 2016
laanwj closed this on Mar 14, 2016
laanwj referenced this in commit 56d2c4e0fe on Mar 14, 2016
codablock referenced this in commit 605143f583 on Sep 16, 2017
codablock referenced this in commit 3bc78faa55 on Sep 19, 2017
codablock referenced this in commit 255cd26231 on Dec 9, 2017
codablock referenced this in commit 8be396a3b8 on Dec 19, 2017
zkbot referenced this in commit 40d5f0aa57 on Oct 26, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6701 GetTempPath is insecure #6702 GetTempPath has unchecked error conditions