torcontrol: rename global base, avoid overlap with field #7676

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_03_torcontrol_rename_base changing 1 files +11 −11

laanwj commented at 9:43 AM on March 14, 2016: member
Avoid overlap with base field in TorController.

This fixes a new warning:
```
torcontrol.cpp:365:24: warning: private field 'base' is not used [-Wunused-private-field]
```

torcontrol: rename global base, avoid overlap with field

Avoid overlap with `base` field in TorController.

This fixes a new warning:

    torcontrol.cpp:365:24: warning: private field 'base' is not used [-Wunused-private-field]

0a48b56bdc

laanwj added the label Refactoring on Mar 14, 2016
laanwj added the label Needs backport on Mar 14, 2016
paveljanik commented at 10:05 AM on March 14, 2016: contributor

Does https://github.com/laanwj/bitcoin/commit/0a48b56bdc60f9dafaea7a7b2a770eb819dbfe55 really fix the warning for you?
laanwj commented at 10:16 AM on March 14, 2016: member

Yes, please verify that this solves your warning @jonasschnelli .
paveljanik commented at 10:19 AM on March 14, 2016: contributor

It does not for me.
laanwj commented at 10:21 AM on March 14, 2016: member

Ok, closing then
laanwj closed this on Mar 14, 2016
MarcoFalke commented at 1:29 PM on April 25, 2016: member

"needs backport" can be removed, as this was never merged.
laanwj removed the label Needs backport on Apr 25, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels