[qt] Remove 0-fee from send dialog #7686

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1603-qt-0-fee changing 3 files +3 −63

MarcoFalke commented at 5:37 PM on March 14, 2016: member

This pull makes -sendfreetransactions a debug feature and removes it from the GUI. Nonetheless, it is still possible to set sendfreetransactions=$bool for the GUI via command line or config arg.
[qt] Remove 0-fee from send dialog fa48bb3148
jonasschnelli added the label GUI on Mar 14, 2016
laanwj commented at 8:26 AM on March 15, 2016: member

The previous proposal was to move this to the coin control window. But I'm fine with this too, as it's still settable on the command line. utACK
jonasschnelli commented at 8:35 AM on March 15, 2016: contributor

Agree with removing it because I don't think its useful to have it in the GUI. Will test...
MarcoFalke commented at 10:06 AM on March 15, 2016: member

It serves no purpose on mainnet, so there is no point in having it prominently in the GUI and confuse users.
in src/qt/forms/sendcoinsdialog.ui:None in fa48bb3148 outdated
```
 616 | @@ -617,7 +617,7 @@
 617 |          <x>0</x>
 618 |          <y>0</y>
 619 |          <width>830</width>
 620 | -        <height>68</height>
 621 | +        <height>104</height>
```
jonasschnelli commented at 11:02 AM on March 15, 2016:

What's the reason for 104px height here? Is it because we have more space now for the scroll area? Currently, this gives some whitespace below the recipient-section-devider (bordered line).
jonasschnelli commented at 11:05 AM on March 15, 2016: contributor

tested ACK fa48bb31484e28a0750d622040616ed04d53053a

I'm happy to get rid of this checkbox which was setting a global state (fSendFreeTransactions) that also affects the RPC/Console interface. Zero fee transactions could be reenabled over CoinControl, thought, allowing it only over RPC/Console is probably better.
paveljanik commented at 7:55 PM on March 15, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/7686/commits/fa48bb31484e28a0750d622040616ed04d53053a
jtimon commented at 4:58 PM on March 16, 2016: contributor

concept ACK
laanwj commented at 12:43 PM on March 17, 2016: member
This leaves one instance of fSendFreeTransactions in src/qt/sendcoinsdialog.cpp
```
    if (!settings.contains("fSendFreeTransactions"))
        settings.setValue("fSendFreeTransactions", false);
```
[qt] Remove unneeded "fSendFreeTransactions" check fae8467d41
MarcoFalke commented at 2:32 PM on March 17, 2016: member

@laanwj Good catch. Removed the dead code.
laanwj commented at 3:20 PM on March 17, 2016: member

utACK fa48bb3
laanwj merged this on Mar 17, 2016
laanwj closed this on Mar 17, 2016
laanwj referenced this in commit f034bced26 on Mar 17, 2016
MarcoFalke deleted the branch on Mar 17, 2016
codablock referenced this in commit 66aa42f490 on Sep 16, 2017
codablock referenced this in commit 9e099c9f51 on Sep 19, 2017
codablock referenced this in commit 430f7f6e7b on Dec 9, 2017
codablock referenced this in commit 721171ee39 on Dec 19, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8287 [wallet] Set fLimitFree = true