Tests: make prioritise_transaction.py more robust #7697

1. 
   sdaftuar commented at 2:27 pm on March 16, 2016: member

   Fixes the issue mentioned here: #7622 (comment)

   This test was too sensitive to how many transactions might get selected; this change makes it more robust, and if there’s a failure due to future changes, the test is now somewhat better structured and commented to make fixing easier.

2. in qa/rpc-tests/prioritise_transaction.py: in 80ab22d4ff outdated

   38 
   39         # Create 3 batches of transactions at 3 different fee rate levels
   40         for i in xrange(3):
   41             txids.append([])
   42-            txids[i] = create_lots_of_big_transactions(self.nodes[0], self.txouts, utxos[30*i:30*i+30], (i+1)*base_fee)
   43+            range_size = utxo_count // 3
   

   ---

   ---

   

   MarcoFalke commented at 3:03 pm on March 16, 2016:

   Nit: this goes in front of the for loop.
3. 
   MarcoFalke commented at 3:06 pm on March 16, 2016: member

   Concept ACK 80ab22d
4. laanwj added the label Tests on Mar 16, 2016
5. 
   laanwj commented at 4:25 pm on March 16, 2016: member

   Nice! utACK 80ab22d
6. sdaftuar force-pushed on Mar 16, 2016
7. 
   sdaftuar commented at 4:30 pm on March 16, 2016: member

   Updated to address @MarcoFalke’s nit
8. 
   MarcoFalke commented at 4:45 pm on March 16, 2016: member

   @sdaftuar Needs rebase
9. Tests: make prioritise_transaction.py more robust ec143391ef
10. sdaftuar force-pushed on Mar 16, 2016
11. 
    sdaftuar commented at 4:55 pm on March 16, 2016: member

    Thanks, rebased.
12. 
    MarcoFalke commented at 5:00 pm on March 16, 2016: member

    utACK ec14339
13. laanwj merged this on Mar 16, 2016
14. laanwj closed this on Mar 16, 2016

    ---

15. laanwj referenced this in commit 622fe6c32f on Mar 16, 2016
16. MarcoFalke referenced this in commit c0d9e31611 on Apr 10, 2016
17. nomnombtc referenced this in commit 9e457879d0 on Nov 11, 2016
18. nomnombtc referenced this in commit eb802872e3 on Nov 11, 2016
19. nomnombtc referenced this in commit 2cca4894b5 on Nov 12, 2016
20. nomnombtc referenced this in commit e11952da3b on Nov 13, 2016
21. sickpig referenced this in commit 604495ed83 on Nov 14, 2016
22. DrahtBot locked this on Sep 8, 2021

Contributors
sdaftuar MarcoFalke laanwj

Labels
Tests