miniupnpc Portfile removed; new and improved macdeployqtplus #770

• My patch for miniupnpc has made it into the latest MacPorts release: https://trac.macports.org/ticket/31354
• Documentation has been changed appropriately
• New pure-Python macdeployqt; leverages all problems with the stock macdeployqt

Additional note: All has been tested and works for me.

Getting: subprocess.CalledProcessError: Command '['strip', '-x', 'dist/Bitcoin-Qt.app/Contents/Frameworks/libssl.1.0.0.dylib']' returned non-zero exit status 1

... because:

bash $ ls -l dist/Bitcoin-Qt.app/Contents/Frameworks/libssl.1.0.0.dylib -r-xr-xr-x 1 gavin gavin 383K Jan 12 11:46 dist/Bitcoin-Qt.app/Contents/Frameworks/libssl.1.0.0.dylib*

bash $ strip -x dist/Bitcoin-Qt.app/Contents/Frameworks/libssl.1.0.0.dylib strip: file: /Users/gavin/src/integration_btc/dist/Bitcoin-Qt.app/Contents/Frameworks/libssl.1.0.0.dylib is not writable (Permission denied)

I'm not sure what the best solution is; either chmod it before (and after) stripping, or skip stripping non-writeable libraries (might be a good assumption that they're system libraries that have already been stripped).

tbh, I chmodded that file long ago in /opt/local/lib/libssl.1.0.0.dylib to get rid of that issue for good. Only a tiny amount of files with the .dylib extension don't have the executable flag set in /opt/local/lib and thus I considered this an error on the MacPorts side.

Any objections to this patch to workaround the MacPorts bug? If not, I'll pull your changes and this patch:

diff --git a/contrib/macdeploy/macdeployqtplus b/contrib/macdeploy/macdeployqtplus
index 914edb7..e159f9b 100755
--- a/contrib/macdeploy/macdeployqtplus
+++ b/contrib/macdeploy/macdeployqtplus
@@ -17,7 +17,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #

-import subprocess, sys, re, os, shutil, os.path
+import subprocess, sys, re, os, shutil, stat, os.path
 from time import sleep
 from argparse import ArgumentParser

@@ -256,7 +256,11 @@ def copyFramework(framework, path, verbose):
     if verbose >= 3:
         print "Copied:", fromPath
         print " to:", toPath
-    
+
+    permissions = os.stat(toPath)
+    if not permissions.st_mode & stat.S_IWRITE:
+      os.chmod(toPath, permissions.st_mode | stat.S_IWRITE)
+
     if not framework.isDylib(): # Copy resources for real frameworks
         fromResourcesDir = framework.sourceResourcesDirectory
         if os.path.exists(fromResourcesDir):

No objections, go ahead.

Pulled