[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock #7702

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1603-qaCleanup2 changing 4 files +23 −2

MarcoFalke commented at 10:27 AM on March 17, 2016: member

No description provided.
[qa] Add tests verifychain, lockunspent, getbalance, listsinceblock fa4a522541
in qa/rpc-tests/mempool_limit.py:None in fa4a522541
```
  37 | @@ -38,7 +38,6 @@ def run_test(self):
  38 |          self.nodes[0].settxfee(0) # return to automatic fee selection
  39 |          txFS = self.nodes[0].signrawtransaction(txF['hex'])
  40 |          txid = self.nodes[0].sendrawtransaction(txFS['hex'])
  41 | -        self.nodes[0].lockunspent(True, [us0])
```
MarcoFalke commented at 10:29 AM on March 17, 2016:

@jonasschnelli I fail to see why you added this noop. I guess you used it for debugging and it is save to remove.

jonasschnelli commented at 12:14 PM on March 17, 2016:

Yes. I guess this can be removed. Should be locked by L39 anyways.

MarcoFalke commented at 1:43 PM on March 17, 2016:

lockunspent(True) will _un_lock, but signrawtransaction does not add any lock.
laanwj added the label Tests on Mar 17, 2016
laanwj commented at 11:18 AM on March 18, 2016: member

ACK fa4a522
laanwj merged this on Mar 18, 2016
laanwj closed this on Mar 18, 2016
laanwj referenced this in commit 29e1131c46 on Mar 18, 2016
MarcoFalke deleted the branch on Mar 18, 2016
MarcoFalke referenced this in commit f23cb7c944 on Apr 5, 2016
nomnombtc referenced this in commit d0bdd79ef8 on Nov 11, 2016
nomnombtc referenced this in commit f817e4cb77 on Nov 12, 2016
nomnombtc referenced this in commit 94ffa552ce on Nov 13, 2016
sickpig referenced this in commit 5500a486c7 on Nov 14, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels