[RPC][QT] UI support for abandoned transactions #7707

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/03/abandon_ui changing 12 files +70 −4

jonasschnelli commented at 7:31 PM on March 17, 2016: contributor

This PR adds the "abandoned" state to the RPC call listtransaction (only outgoing transactions), it also adds a context menu option to abandon a transaction over the GUI.

Abandoned transaction are marked with a light-red color and a "trash" icon.

Some screens: <img width="1056" alt="bildschirmfoto 2016-03-17 um 20 04 17" src="https://cloud.githubusercontent.com/assets/178464/13858483/32d94ed4-ec7f-11e5-8909-59df5b245a5a.png"> <img width="732" alt="bildschirmfoto 2016-03-17 um 20 04 09" src="https://cloud.githubusercontent.com/assets/178464/13858486/34038a54-ec7f-11e5-9dc0-70b255a5be40.png"> <img width="319" alt="bildschirmfoto 2016-03-17 um 20 31 17" src="https://cloud.githubusercontent.com/assets/178464/13858496/38a1a5c8-ec7f-11e5-8f72-767b69f233d7.png">
jonasschnelli force-pushed on Mar 17, 2016
jonasschnelli added the label GUI on Mar 17, 2016
jonasschnelli added the label RPC on Mar 17, 2016
jonasschnelli force-pushed on Mar 17, 2016
jonasschnelli force-pushed on Mar 17, 2016
jonasschnelli force-pushed on Mar 17, 2016
jonasschnelli force-pushed on Mar 17, 2016
jonasschnelli commented at 8:48 AM on March 18, 2016: contributor
Added serval things:
- table row will be updated (redrawn) after a transaction has been abandoned (new color / change icon)
- "Abandon transaction" action is only available if tx is not in mempool and has no confirmation (otherwise it's disabled)
- Simple reordering of the context menu (keep mutable action together)
<img width="246" alt="bildschirmfoto 2016-03-18 um 09 46 20" src="https://cloud.githubusercontent.com/assets/178464/13872971/81d2fcdc-ecee-11e5-973a-8f4513e0ff8c.png">
laanwj commented at 12:50 PM on March 23, 2016: member

Concept ACK
morcos commented at 2:44 PM on March 23, 2016: member

utACK on 42e945d only for backport to 0.12
in src/Makefile.qt.include:None in df80f3d097 outdated
```
 267 | @@ -268,7 +268,8 @@ RES_ICONS = \
 268 |    qt/res/icons/tx_output.png \
 269 |    qt/res/icons/tx_mined.png \
 270 |    qt/res/icons/warning.png \
 271 | -  qt/res/icons/verify.png
 272 | +  qt/res/icons/verify.png \
 273 | +  qt/res/icons/transaction_abandoned.png
```
MarcoFalke commented at 11:37 AM on March 24, 2016:

Nit: Document the author?

Edit: Also you may want to consider adding the source svg and running optimize png, if not already done.

jonasschnelli commented at 7:24 AM on April 4, 2016:

It's already optimized and the source SVG is not required because it's part of Hutchings typicons (we only added sourced for manipulated or self-created icons). Also src/qt/res/icons/transaction*.png covers the copyright info in contrib/debian/copyright.

MarcoFalke commented at 7:38 AM on April 4, 2016:

Thanks for clarifying, I haven't seen this is unmodified.

in src/wallet/rpcwallet.cpp:None in df80f3d097 outdated

1345 | @@ -1346,6 +1346,7 @@ void ListTransactions(const CWalletTx& wtx, const string& strAccount, int nMinDe
1346 |              entry.push_back(Pair("fee", ValueFromAmount(-nFee)));
1347 |              if (fLong)
1348 |                  WalletTxToJSON(wtx, entry);
1349 | +            entry.push_back(Pair("abandoned", wtx.isAbandoned()));

MarcoFalke commented at 11:49 AM on March 24, 2016:

Nit: This is already merged? Needs rebase?

MarcoFalke commented at 2:20 PM on March 24, 2016:

Also it looks like you forgot to add the documentation here?

MarcoFalke commented at 2:19 PM on March 24, 2016: member

Tested ACK df80f3d
paveljanik commented at 2:48 PM on March 30, 2016: contributor

@jonasschnelli can you please rebase so the rpcwallet.cpp file is not touched here?
jonasschnelli force-pushed on Mar 30, 2016
jonasschnelli commented at 3:09 PM on March 30, 2016: contributor

Rebased.
paveljanik commented at 4:14 PM on March 30, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/7707/commits/3d580e55599c0a911ba79a5c0df94b4391d4dae4

For other testers: start with -walletbroadcast=0.
[Qt] Support for abandoned/abandoning transactions 8efed3bc93
jonasschnelli force-pushed on Apr 4, 2016
jonasschnelli merged this on Apr 4, 2016
jonasschnelli closed this on Apr 4, 2016
jonasschnelli referenced this in commit a9149688f8 on Apr 4, 2016
codablock referenced this in commit 3d47117242 on Sep 7, 2017
UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels