Travis test (not to merge): Introduce silent bug in CFeeRate #7727

1. 
   jtimon commented at 1:55 pm on March 21, 2016: contributor

   This passes unittests and python ./qa/pull-tester/rpc-tests.py -extended. I just want to make sure this passes travis before proposing a test that would make this change fail. I know it may not be very important or a priority right now, but since I have it done already, one more check in the unittests won’t harm. Please, don’t merge.
2. UNDO: Introduce silent bug in CFeeRate 53244fef19
3. 
   MarcoFalke commented at 1:59 pm on March 21, 2016: member

   I don’t think this constructor is used right now, so the compiler will probably wipe it and it should not make a difference for travis.
4. 
   jtimon commented at 2:04 pm on March 21, 2016: contributor

   If it wasn’t used, my new test (see #7728 ) shouldn’t fail with this change either, but it does.
5. 
   laanwj commented at 3:50 pm on March 21, 2016: member

   Good catch, this definitely needs a test
6. 
   MarcoFalke commented at 4:32 pm on March 21, 2016: member

   Indeed, it is used. Happy to review if you submit the patch for the tests.
7. 
   jtimon commented at 4:58 pm on March 21, 2016: contributor

   I’m glad that this is helpful, the fix test is in #7728 (sorry, I opened the PR without paying attention to github, which was telling me I needed to rebase on top of #7705 ).

   I actually “wasted” much more time than expected on a draft branch to make a point that shouldn’t have taken me much time because this test didn’t exist. But what I did is kind of a long story with some embarrassing parts that I’m still not sure I want to publish. More details in a follow up discussion PR though (separated from #7728 ).

   Anyway, point made, closing this now, please go to #7728 to review the additional test.

8. jtimon closed this on Mar 21, 2016

   ---

9. DrahtBot locked this on Sep 8, 2021

Contributors
jtimon MarcoFalke laanwj