[Qt] Debug window: replace “Build date” with “Datadir” #7732

1. 
   jonasschnelli commented at 7:46 am on March 22, 2016: contributor

   The build date does only make sense for custom/self-compiled bitcoin-core versions because we are using static build-dates for our deterministic release builds.

   Having a quick option to get the current datadir is much more valuable for debug purposes.

   I could optional re-add the build-date for self compiled versions if someone brings up a concrete reason/value to keep it.

   Optional this could be extended to open the datadir in the OS file explore when someone clicks on the label (Would require some platform dependent code: http://stackoverflow.com/questions/3490336/how-to-reveal-in-finder-or-show-in-explorer-with-qt).

2. [Qt] Debug window: replace "Build date" with "Datadir"

   The build date does only makes sense for custom/self-compiled bitcoin-core versions because we are using static build-dates for our deterministic release builds.
   Having a quick option to get the current datadir is much more valuable for debug purposes.

   4856f1d671
3. jonasschnelli added the label GUI on Mar 22, 2016
4. 
   laanwj commented at 10:59 am on March 22, 2016: member

   Awesome, ACK 4856f1d

   Optional this could be extended to open the datadir in the OS file explore when someone clicks on the label

   This couldn’t use the same functionality that we use to open the debug log?

   OTOH we don’t want to make it too easy to mess around in the data directory, certainly not while the application is running. Probably just showing it is good enough.

5. 
   MarcoFalke commented at 11:15 am on March 24, 2016: member

   I could optional re-add the build-date for self compiled versions if someone brings up a concrete reason/value to keep it.

   We already display the commit-hash, which identifies the code that was compiled.

   ACK 4856f1d

6. 
   laanwj commented at 1:51 pm on March 24, 2016: member

   We already display the commit-hash, which identifies the code that was compiled.

   Yes, exactly, what is important is what was compiled, not when.

7. 
   laanwj commented at 1:54 pm on March 24, 2016: member

   Nits:

   • formatBuildDate is unused after this, and can go

   We can either do there here, or in a pull that completely removes CLIENT_DATE/BUILD_DATE, I don’t mind.

8. 
   MarcoFalke commented at 2:02 pm on March 24, 2016: member

   Good catch. Should be at least another commit as it is unrelated to the GUI.
9. 
   laanwj commented at 2:14 pm on March 24, 2016: member

   Well, ClientModel::formatBuildDate is part of the GUI code, so could be removed here.

   I indeed agree removing CLIENT_DATE/BUILD_DATE should be a separate pull, as it is unrelated to the GUI.

10. [Qt] remove unused formatBuildDate method fc737d127f
11. 
    jonasschnelli commented at 8:50 pm on March 24, 2016: contributor

    Right. I wasn’t sure if we want to re-add the formatted build date somewhere. Just added a commit that removes the now unused method.
12. 
    laanwj commented at 10:13 am on March 25, 2016: member

    Had to re-trigger Travis due to an unrelated problem (#7463)
13. laanwj merged this on Mar 25, 2016
14. laanwj closed this on Mar 25, 2016

    ---

15. laanwj referenced this in commit 0b98dd7939 on Mar 25, 2016
16. laanwj referenced this in commit 8fef47b644 on Mar 26, 2016
17. laanwj referenced this in commit 5c852b75f2 on Jun 9, 2016
18. laanwj referenced this in commit f6e201da0a on Jun 9, 2016
19. laanwj referenced this in commit d096d22446 on Jun 9, 2016
20. cddjr referenced this in commit 46779d35d5 on Apr 5, 2017
21. cddjr referenced this in commit 27e9b94e4d on Apr 6, 2017
22. codablock referenced this in commit d600608fa0 on Sep 7, 2017
23. UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
24. lateminer referenced this in commit 106eaff884 on Jan 5, 2018
25. furszy referenced this in commit 55ec1ee45e on Aug 23, 2021
26. Fuzzbawls referenced this in commit 5a64b279b3 on Sep 2, 2021
27. MarcoFalke locked this on Sep 8, 2021

Contributors
jonasschnelli laanwj MarcoFalke

Labels
GUI