devtools: make github-merge.py use py3 #7737

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_03_python_3_github_merge changing 1 files +13 −7
  1. laanwj commented at 11:47 AM on March 23, 2016: member

    This makes github-merge.py the first developer tool to go all Python 3 (for context see #7717).

    The changes are straightforward as the script already was from __future__ import division,print_function,unicode_literals.

    However urllib2 changed name, and json will only accept unicode data not bytes.

    This retains py2 compatibility for now: not strictly necessary as the script is not used by the build system (see #7723) - but it was easy.

  2. laanwj added the label Dev Scripts on Mar 23, 2016
  3. laanwj force-pushed on Mar 23, 2016
  4. devtools: make github-merge.py use py3
    This makes github-merge.py the first developer tool to go
    all Python 3 (for context see #7717).
    
    The changes are straightforward as the script already was
    `from __future__ import division,print_function,unicode_literals`.
    
    However urllib2 changed name, and json will only accept unicode data not
    bytes.
    
    This retains py2 compatibility for now: not strictly necessary
    as it's not used by the build system - but it was easy.
    f11c5a3cbd
  5. laanwj force-pushed on Mar 23, 2016
  6. MarcoFalke commented at 10:42 AM on March 24, 2016: member

    utACK f11c5a3

  7. laanwj commented at 9:07 AM on March 29, 2016: member

    I've been using this python3 version for about a week now, without problems. so tested ACK on my own pull

  8. laanwj merged this on Mar 29, 2016
  9. laanwj closed this on Mar 29, 2016

  10. laanwj referenced this in commit aa0d2b2631 on Mar 29, 2016
  11. codablock referenced this in commit 4903fa8129 on Sep 16, 2017
  12. codablock referenced this in commit eb57a1db33 on Sep 19, 2017
  13. codablock referenced this in commit 6539095eac on Dec 9, 2017
  14. codablock referenced this in commit 34701da5cb on Dec 19, 2017
  15. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me