[Wallet][RPC] add missing abandon status documentation #7742

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/03/ab_doc changing 1 files +1 −0

jonasschnelli commented at 8:45 PM on March 24, 2016: contributor

No description provided.
jonasschnelli added the label Wallet on Mar 24, 2016
jonasschnelli added the label RPC on Mar 24, 2016

in src/wallet/rpcwallet.cpp:None in 99400a5927 outdated

1438 | @@ -1439,6 +1439,7 @@ UniValue listtransactions(const UniValue& params, bool fHelp)
1439 |              "    \"vout\": n,                (numeric) the vout value\n"
1440 |              "    \"fee\": x.xxx,             (numeric) The amount of the fee in " + CURRENCY_UNIT + ". This is negative and only available for the \n"
1441 |              "                                         'send' category of transactions.\n"
1442 | +            "    \"abandoned\": xxx          (bool) Wether the transaction has been abandoned (inputs are respenable).

paveljanik commented at 9:28 PM on March 24, 2016:

whether (shouldn't it be "If" instead?), respendable.

laanwj commented at 10:24 AM on March 25, 2016: member

wallet/rpcwallet.cpp:1442:13: warning: missing terminating " character [enabled by default]
wallet/rpcwallet.cpp:1442:13: error: missing terminating " character

jonasschnelli force-pushed on Mar 25, 2016
jonasschnelli force-pushed on Mar 25, 2016
jonasschnelli commented at 10:30 AM on March 25, 2016: contributor

wallet/rpcwallet.cpp:1442:13: warning: missing terminating " character [enabled by default] wallet/rpcwallet.cpp:1442:13: error: missing terminating " character

Fixed. This is what you get when you think you don't need to compile simple text changes!

in src/wallet/rpcwallet.cpp:None in ccbd5a14d5 outdated

1438 | @@ -1439,6 +1439,7 @@ UniValue listtransactions(const UniValue& params, bool fHelp)
1439 |              "    \"vout\": n,                (numeric) the vout value\n"
1440 |              "    \"fee\": x.xxx,             (numeric) The amount of the fee in " + CURRENCY_UNIT + ". This is negative and only available for the \n"
1441 |              "                                         'send' category of transactions.\n"
1442 | +            "    \"abandoned\": xxx          (bool) 'true' if the transaction has been abandoned (inputs are respenable).\n"

laanwj commented at 10:36 AM on March 25, 2016:

s/respenable/respendable/

laanwj commented at 10:38 AM on March 25, 2016: member

This is what you get when you think you don't need to compile simple text changes!

Hehe, yes, my experience too! Rushed changed usually take at least three times as long :)
[Wallet][RPC] add missing abandon status documentation cef8bdf5d7
jonasschnelli force-pushed on Mar 29, 2016
jonasschnelli commented at 6:43 AM on March 29, 2016: contributor

Fixed the typo.
paveljanik commented at 6:55 AM on March 29, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/7742/commits/cef8bdf5d747d42c3be473d7ef38052eebd5e9bd
laanwj merged this on Mar 29, 2016
laanwj closed this on Mar 29, 2016
laanwj referenced this in commit 2676e12016 on Mar 29, 2016
codablock referenced this in commit 06b527d7a1 on Sep 16, 2017
codablock referenced this in commit cfd9e6f85e on Sep 19, 2017
codablock referenced this in commit 0c6d926f08 on Dec 9, 2017
codablock referenced this in commit ca33635ef7 on Dec 19, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels